Re: pg_basebackup fails on databases with high OIDs

2020-01-13 Thread Julien Rouhaud
On Mon, Jan 13, 2020 at 1:49 PM Peter Eisentraut wrote: > > On 2020-01-11 17:47, Magnus Hagander wrote: > > On Sat, Jan 11, 2020 at 5:44 PM Julien Rouhaud wrote: > >> > >> On Sat, Jan 11, 2020 at 08:21:11AM +0100, Peter Eisentraut wrote: > >>> On 2020-01-06 21:00, Magnus Hagander wrote: > > +

Re: pg_basebackup fails on databases with high OIDs

2020-01-13 Thread Peter Eisentraut
On 2020-01-11 17:47, Magnus Hagander wrote: On Sat, Jan 11, 2020 at 5:44 PM Julien Rouhaud wrote: On Sat, Jan 11, 2020 at 08:21:11AM +0100, Peter Eisentraut wrote: On 2020-01-06 21:00, Magnus Hagander wrote: +0.5 to avoid calling OidInputFunctionCall() Or just directly using atol() instead

Re: pg_basebackup fails on databases with high OIDs

2020-01-11 Thread Magnus Hagander
On Sat, Jan 11, 2020 at 5:44 PM Julien Rouhaud wrote: > > On Sat, Jan 11, 2020 at 08:21:11AM +0100, Peter Eisentraut wrote: > > On 2020-01-06 21:00, Magnus Hagander wrote: > > > > +0.5 to avoid calling OidInputFunctionCall() > > > > > > Or just directly using atol() instead of atoi()? Well maybe n

Re: pg_basebackup fails on databases with high OIDs

2020-01-11 Thread Julien Rouhaud
On Sat, Jan 11, 2020 at 08:21:11AM +0100, Peter Eisentraut wrote: > On 2020-01-06 21:00, Magnus Hagander wrote: > > > +0.5 to avoid calling OidInputFunctionCall() > > > > Or just directly using atol() instead of atoi()? Well maybe not > > directly but in a small wrapper that verifies it's not bigge

Re: pg_basebackup fails on databases with high OIDs

2020-01-10 Thread Peter Eisentraut
On 2020-01-06 21:00, Magnus Hagander wrote: +0.5 to avoid calling OidInputFunctionCall() Or just directly using atol() instead of atoi()? Well maybe not directly but in a small wrapper that verifies it's not bigger than an unsigned? Unlike in cases where we use oidin etc, we are dealing with d

Re: pg_basebackup fails on databases with high OIDs

2020-01-06 Thread Magnus Hagander
On Mon, Jan 6, 2020 at 9:31 AM Julien Rouhaud wrote: > > On Mon, Jan 6, 2020 at 9:21 AM Michael Paquier wrote: > > > > On Mon, Jan 06, 2020 at 09:07:26AM +0100, Peter Eisentraut wrote: > > > This is a new bug in PG12. When you have a database with an OID above > > > INT32_MAX (signed), then pg_b

Re: pg_basebackup fails on databases with high OIDs

2020-01-06 Thread Julien Rouhaud
On Mon, Jan 6, 2020 at 9:21 AM Michael Paquier wrote: > > On Mon, Jan 06, 2020 at 09:07:26AM +0100, Peter Eisentraut wrote: > > This is a new bug in PG12. When you have a database with an OID above > > INT32_MAX (signed), then pg_basebackup fails thus: > > Yep. Introduced by 6b9e875. Indeed. >

Re: pg_basebackup fails on databases with high OIDs

2020-01-06 Thread Michael Paquier
On Mon, Jan 06, 2020 at 09:07:26AM +0100, Peter Eisentraut wrote: > This is a new bug in PG12. When you have a database with an OID above > INT32_MAX (signed), then pg_basebackup fails thus: Yep. Introduced by 6b9e875. > pg_basebackup: error: could not get write-ahead log end position from > se