Re: pg_basebackup -k option

2018-05-21 Thread Peter Eisentraut
On 5/18/18 11:26, Michael Banck wrote: >>> How about using capital -K in pg_basebackup? Or maybe it doesn't need a >>> short option at all. >> >> +1 for no short option. > > Makes sense to me, I wasn't happy about the -k back then (and I think I > solicited feedback on that). > > PFA a patch whi

Re: pg_basebackup -k option

2018-05-18 Thread Magnus Hagander
On Fri, May 18, 2018 at 4:46 PM, Tom Lane wrote: > Peter Eisentraut writes: > > The new pg_basebackup -k option stands for --no-verify-checksums. That > > is nearly the opposite of initdb -k, which is for enabling checksums. I > > think it could be confusing to have two related tools use the s

Re: pg_basebackup -k option

2018-05-18 Thread Michael Banck
Hi, On Fri, May 18, 2018 at 10:46:37AM -0400, Tom Lane wrote: > Peter Eisentraut writes: > > The new pg_basebackup -k option stands for --no-verify-checksums. That > > is nearly the opposite of initdb -k, which is for enabling checksums. I > > think it could be confusing to have two related too

Re: pg_basebackup -k option

2018-05-18 Thread Tom Lane
Peter Eisentraut writes: > The new pg_basebackup -k option stands for --no-verify-checksums. That > is nearly the opposite of initdb -k, which is for enabling checksums. I > think it could be confusing to have two related tools use the same > option letter for nearly opposite purposes. > How ab

Re: pg_basebackup -k option

2018-05-18 Thread Sergei Kornilov
Hi I think having only long option is enough regards, Sergei