Re: pg_basebackup: Missing newlines in some error messages

2018-03-21 Thread Alvaro Herrera
Michael Banck wrote: > Hi, > > Am Mittwoch, den 21.03.2018, 09:54 -0300 schrieb Alvaro Herrera: > > Michael Banck wrote: > > > I apparently managed to screw up so badly that no PQerrorMessage was > > > set, so saw the above (which indeed has no error message after the > > > colon). > > > > Well,

Re: pg_basebackup: Missing newlines in some error messages

2018-03-21 Thread Michael Banck
Hi, Am Mittwoch, den 21.03.2018, 09:54 -0300 schrieb Alvaro Herrera: > Michael Banck wrote: > > I apparently managed to screw up so badly that no PQerrorMessage was > > set, so saw the above (which indeed has no error message after the > > colon). > > Well, maybe that's a different bug, then: may

Re: pg_basebackup: Missing newlines in some error messages

2018-03-21 Thread Alvaro Herrera
Alvaro Herrera wrote: > Hi > > Michael Banck wrote: > > > I apparently managed to screw up so badly that no PQerrorMessage was > > set, so saw the above (which indeed has no error message after the > > colon). > > Well, maybe that's a different bug, then: maybe we should print > something other

Re: pg_basebackup: Missing newlines in some error messages

2018-03-21 Thread Alvaro Herrera
Hi Michael Banck wrote: > I apparently managed to screw up so badly that no PQerrorMessage was > set, so saw the above (which indeed has no error message after the > colon). Well, maybe that's a different bug, then: maybe we should print something other than PQerrorMessage (or maybe PQerrorMessa

Re: pg_basebackup: Missing newlines in some error messages

2018-03-21 Thread Michael Banck
Hi, Am Mittwoch, den 21.03.2018, 09:46 -0300 schrieb Alvaro Herrera: > Daniel Gustafsson wrote: > > > On 21 Mar 2018, at 13:12, Michael Banck wrote: > > > while working on something else, I noticed that some error messages in > > > pg_basebackup do not have a "\n" at the end, resulting in output

Re: pg_basebackup: Missing newlines in some error messages

2018-03-21 Thread Alvaro Herrera
Daniel Gustafsson wrote: > > On 21 Mar 2018, at 13:12, Michael Banck wrote: > > > while working on something else, I noticed that some error messages in > > pg_basebackup do not have a "\n" at the end, resulting in output like: > > > > |pg_basebackup: could not get COPY data stream: pg_basebacku

Re: pg_basebackup: Missing newlines in some error messages

2018-03-21 Thread Daniel Gustafsson
> On 21 Mar 2018, at 13:12, Michael Banck wrote: > while working on something else, I noticed that some error messages in > pg_basebackup do not have a "\n" at the end, resulting in output like: > > |pg_basebackup: could not get COPY data stream: pg_basebackup: removing > |data directory “data2"