Re: partition -> partitioned

2018-06-20 Thread Amit Langote
On 2018/06/21 0:45, Alvaro Herrera wrote: > On 2018-Jun-19, Amit Langote wrote: > >> Noticed that the relevant code changed, so I rebased the patch. Also, >> made a minor update to a nearby comment. > > Pushed, thanks. I made a couple of comments one or two words shorter > while (IMO) not losin

Re: partition -> partitioned

2018-06-20 Thread Alvaro Herrera
On 2018-Jun-19, Amit Langote wrote: > Noticed that the relevant code changed, so I rebased the patch. Also, > made a minor update to a nearby comment. Pushed, thanks. I made a couple of comments one or two words shorter while (IMO) not losing clarity. -- Álvaro Herrerahttps://

Re: partition -> partitioned

2018-06-19 Thread Alvaro Herrera
On 2018-Jun-20, Michael Paquier wrote: > On Tue, Jun 19, 2018 at 06:02:22PM +0900, Amit Langote wrote: > > Noticed that the relevant code changed, so I rebased the patch. Also, > > made a minor update to a nearby comment. > > That looks right to me as we speak about non-leaf partitions here. > A

Re: partition -> partitioned

2018-06-19 Thread Michael Paquier
On Tue, Jun 19, 2018 at 06:02:22PM +0900, Amit Langote wrote: > Noticed that the relevant code changed, so I rebased the patch. Also, > made a minor update to a nearby comment. That looks right to me as we speak about non-leaf partitions here. Alvaro, as 499be013 is yours, would you fix this inco

Re: partition -> partitioned

2018-06-19 Thread Amit Langote
On 2018/06/19 17:51, Amit Langote wrote: > On 2018/05/17 11:48, Amit Langote wrote: >> On 2018/05/17 11:40, David Rowley wrote: >>> On 17 May 2018 at 13:52, Amit Langote wrote: Commit 499be013de6 used 'partition' where it really meant 'partitioned' in a few places including in a variable

Re: partition -> partitioned

2018-06-19 Thread Amit Langote
On 2018/05/17 11:48, Amit Langote wrote: > On 2018/05/17 11:40, David Rowley wrote: >> On 17 May 2018 at 13:52, Amit Langote wrote: >>> Commit 499be013de6 used 'partition' where it really meant 'partitioned' in >>> a few places including in a variable name. For example, what almost all >>> places

Re: partition -> partitioned

2018-05-16 Thread Amit Langote
On 2018/05/17 11:40, David Rowley wrote: > On 17 May 2018 at 13:52, Amit Langote wrote: >> Commit 499be013de6 used 'partition' where it really meant 'partitioned' in >> a few places including in a variable name. For example, what almost all >> places call 'partitioned_rels', make_partition_prunei

Re: partition -> partitioned

2018-05-16 Thread David Rowley
On 17 May 2018 at 13:52, Amit Langote wrote: > Commit 499be013de6 used 'partition' where it really meant 'partitioned' in > a few places including in a variable name. For example, what almost all > places call 'partitioned_rels', make_partition_pruneinfo called > 'partition_rels'. > > Attached a