On Wed, Dec 8, 2021 at 2:51 PM Michael Paquier wrote:
>
> On Tue, Dec 07, 2021 at 08:12:59AM +1100, Peter Smith wrote:
> > On Tue, Dec 7, 2021 at 6:07 AM Bossart, Nathan wrote:
> >> Attached a v14 with the initializations added back.
> >
> > LGTM.
>
> All the code paths previously covered still a
On Tue, Dec 07, 2021 at 08:12:59AM +1100, Peter Smith wrote:
> On Tue, Dec 7, 2021 at 6:07 AM Bossart, Nathan wrote:
>> Attached a v14 with the initializations added back.
>
> LGTM.
All the code paths previously covered still are, so applied this one.
Thanks!
--
Michael
signature.asc
Descripti
On Tue, Dec 7, 2021 at 6:07 AM Bossart, Nathan wrote:
>
> On 12/5/21, 9:21 PM, "Michael Paquier" wrote:
> > On Mon, Dec 06, 2021 at 11:28:12AM +1100, Peter Smith wrote:
> >> For the initialization of opts I put memset within the function to
> >> make it explicit that the bit-masks will work as in
On Mon, Dec 06, 2021 at 11:28:12AM +1100, Peter Smith wrote:
> For the initialization of opts I put memset within the function to
> make it explicit that the bit-masks will work as intended without
> having to look back at calling code for the initial values. In any
> case, I think the caller decla
On Fri, Dec 3, 2021 at 11:02 AM Bossart, Nathan wrote:
>
> On 8/8/21, 11:54 PM, "Peter Smith" wrote:
> > v11 -> v12
> >
> > * A rebase was needed due to some recent pgindent changes on HEAD.
>
> The patch looks correct to me. I have a couple of small comments.
Thank you for taking an interest i
v11 -> v12
* A rebase was needed due to some recent pgindent changes on HEAD.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
v12-0001-Simplify-recent-parse_subscription_option-change.patch
Description: Binary data
