Re: optimizer/clauses.h needn't include access/htup.h

2020-12-20 Thread Andres Freund
Hi, On 2020-11-23 19:44:37 -0300, Alvaro Herrera wrote: > I was contemplating commands/trigger.c this morning (after Heikki split > copy.c) thinking about the three pieces embedded in there -- one > catalog/pg_trigger.c, one in executor (execTrigger.c?) and what seems a > very small piece to remai

Re: optimizer/clauses.h needn't include access/htup.h

2020-11-23 Thread Alvaro Herrera
On 2020-Nov-23, Tom Lane wrote: > Anyway, if you're feeling motivated to explore a more wide-ranging > refactoring, by all means have a go at it. I was contemplating commands/trigger.c this morning (after Heikki split copy.c) thinking about the three pieces embedded in there -- one catalog/pg_tri

Re: optimizer/clauses.h needn't include access/htup.h

2020-11-23 Thread Tom Lane
Justin Pryzby writes: > It was only needed between these: > commit a8677e3ff6bb8ef78a9ba676faa647bba237b1c4 > commit f09346a9c6218dd239fdf3a79a729716c0d305bd Hm, you're right. Removed. > I noticed while looking at "what includes what" and wondered if some of these > are kind of "modularity viol