Re: naming of async_mode parameter

2021-05-16 Thread Etsuro Fujita
Hi, On Fri, May 14, 2021 at 9:00 PM Zhihong Yu wrote: > Searching postgres codebase reveals the following (partial) examples: > > bool is_varlena > bool is_leaf > > I think these are more intuitive. > > If you think is_in_async_mode is too long, how about naming the parameter > is_async ? Sorry

Re: naming of async_mode parameter

2021-05-14 Thread Zhihong Yu
On Fri, May 14, 2021 at 1:05 AM Etsuro Fujita wrote: > Hi, > > On Thu, May 13, 2021 at 2:23 AM Zhihong Yu wrote: > > I was looking at > > Fix EXPLAIN ANALYZE for async-capable nodes. > > Thanks for that! > > > which adds the following parameter / field: > > > > + boolasync_mode;

Re: naming of async_mode parameter

2021-05-14 Thread Etsuro Fujita
Hi, On Thu, May 13, 2021 at 2:23 AM Zhihong Yu wrote: > I was looking at > Fix EXPLAIN ANALYZE for async-capable nodes. Thanks for that! > which adds the following parameter / field: > > + boolasync_mode; /* true if node is in async mode */ > > async_mode implies an enum: {sync,