Re: move hash_any to utils/hash/hashfn.c

2019-03-11 Thread Alvaro Herrera
On 2019-Jan-25, Alvaro Herrera wrote: > Would anybody object too hard if I move hash_any() and friends to > src/backend/utils/hash/hashfn.c and the declarations to > src/include/utils/hashutils.h? Pushed this. I ended up adding an #include of utils/hashutils.h to access/hash.h, so that any third

Re: move hash_any to utils/hash/hashfn.c

2019-01-29 Thread Alvaro Herrera
Hello On 2019-Jan-25, Andres Freund wrote: > I hate the current split quite a bit, albeit for somewhat different > reasons. We make things like tag_hash, uint32_hash unnecessarily more > expensive by adding an entirely useless external function call. And > some of these can be fairly hot (e.g. fo

Re: move hash_any to utils/hash/hashfn.c

2019-01-25 Thread Tom Lane
Andres Freund writes: > On 2019-01-25 16:35:18 -0300, Alvaro Herrera wrote: >> Would anybody object too hard if I move hash_any() and friends to >> src/backend/utils/hash/hashfn.c and the declarations to >> src/include/utils/hashutils.h? > I hate the current split quite a bit, albeit for somewhat

Re: move hash_any to utils/hash/hashfn.c

2019-01-25 Thread Andres Freund
Hi, On 2019-01-25 16:35:18 -0300, Alvaro Herrera wrote: > I just noticed (once again) that we have hash_any() declared in > src/access/hash.h (the header file for the hash index AM) rather than > somewhere in utils/, for no good reason other than perhaps there was no > better place when it was int