The patch is currently not applying.
And it looks like there hasn't been any discussion since Alvaro's
comments last december. I'm marking the patch Returned with Feedback.
On Fri, 24 Dec 2021 at 16:49, Alvaro Herrera wrote:
>
> On 2021-Dec-21, Mark Dilger wrote:
>
> > Rebased patch attached:
>
On 2021-Dec-21, Mark Dilger wrote:
> Rebased patch attached:
These tests are boringly repetitive. Can't we have something like a
nested loop, with AMs on one and reloptions on the other, where each
reloption is tried on each AM and an exception block to report the
failure or success for each cas
Rebased patch attached:
v3-0001-Reject-storage-options-in-toast-namespace-in-view.patch
Description: Binary data
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
> On Oct 1, 2021, at 12:34 PM, Mark Dilger wrote:
>
> The patch does it this way.
A rebased patch is attached.
v2-0001-Reject-storage-options-in-toast-namespace-in-view.patch
Description: Binary data
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan
> On Oct 1, 2021, at 6:15 AM, Alvaro Herrera wrote:
>
> On 2021-Sep-30, Mark Dilger wrote:
>
>> The solution is simple enough: stop using HEAP_RELOPT_NAMESPACES when
>> parsing reloptions for views and instead create a
>> VIEW_RELOPT_NAMESPACES array which does not include "toast".
>
> It se
On 2021-Sep-30, Mark Dilger wrote:
> The solution is simple enough: stop using HEAP_RELOPT_NAMESPACES when
> parsing reloptions for views and instead create a
> VIEW_RELOPT_NAMESPACES array which does not include "toast".
It seems a reasonable (non-backpatchable) change to me.
> I've already fi