Re: mem context is not reset between extended stats

2021-09-23 Thread Tomas Vondra
Hi, I've pushed both of these patches, with some minor tweaks (freeing the statistics list, and deleting the new context), and backpatched them all the way to 10. Thanks for the report & patch, Justin! regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgre

Re: mem context is not reset between extended stats

2021-09-21 Thread Tomas Vondra
On 9/21/21 3:37 AM, Justin Pryzby wrote: > On Tue, Sep 21, 2021 at 02:15:45AM +0200, Tomas Vondra wrote: >> On 9/15/21 10:09 PM, Justin Pryzby wrote: >>> Memory allocation appeared be O(1) WRT the number of statistics objects, >>> which >>> was not expected to me. This is true in v13 (and probabl

Re: mem context is not reset between extended stats

2021-09-20 Thread Justin Pryzby
On Tue, Sep 21, 2021 at 02:15:45AM +0200, Tomas Vondra wrote: > On 9/15/21 10:09 PM, Justin Pryzby wrote: > > Memory allocation appeared be O(1) WRT the number of statistics objects, > > which > > was not expected to me. This is true in v13 (and probably back to v10). Of course I meant to say th

Re: mem context is not reset between extended stats

2021-09-20 Thread Tomas Vondra
On 9/15/21 10:09 PM, Justin Pryzby wrote: Memory allocation appeared be O(1) WRT the number of statistics objects, which was not expected to me. This is true in v13 (and probably back to v10). It seems to work fine to reset the memory context within the loop, so long as the statslist is alloca