Re: logical/relation.c header description

2020-09-17 Thread Amit Kapila
On Fri, Sep 18, 2020 at 9:07 AM Amit Langote wrote: > > On Fri, Sep 18, 2020 at 12:30 PM Amit Kapila wrote: > > I am not very excited to add information about structures used in the > > file especially when we have explained 'LogicalRepPartMapEntry' a few > > lines after. I think we can leave exp

Re: logical/relation.c header description

2020-09-17 Thread Amit Langote
On Fri, Sep 18, 2020 at 12:30 PM Amit Kapila wrote: > On Thu, Sep 17, 2020 at 6:46 PM Amit Langote wrote: > > > > Thanks for taking a look. > > > > On Thu, Sep 17, 2020 at 9:20 PM Amit Kapila wrote: > > > On Thu, Sep 17, 2020 at 3:22 PM Amit Langote > > > wrote: > > > > > > > > > > > > > /*-

Re: logical/relation.c header description

2020-09-17 Thread Amit Kapila
On Thu, Sep 17, 2020 at 6:46 PM Amit Langote wrote: > > Thanks for taking a look. > > On Thu, Sep 17, 2020 at 9:20 PM Amit Kapila wrote: > > On Thu, Sep 17, 2020 at 3:22 PM Amit Langote > > wrote: > > > > > > > /*- > > *

Re: logical/relation.c header description

2020-09-17 Thread Amit Langote
Thanks for taking a look. On Thu, Sep 17, 2020 at 9:20 PM Amit Kapila wrote: > On Thu, Sep 17, 2020 at 3:22 PM Amit Langote wrote: > > > > /*- > * relation.c > - *PostgreSQL logical replication > + *PostgreSQL log

Re: logical/relation.c header description

2020-09-17 Thread Amit Kapila
On Thu, Sep 17, 2020 at 3:22 PM Amit Langote wrote: > /*- * relation.c - *PostgreSQL logical replication + *PostgreSQL logical replication relation mapping routines * .. * NOTES * This file contains helper fu