Re: location reporting in TAP test failures

2018-07-01 Thread Michael Paquier
On Sun, Jul 01, 2018 at 01:17:07PM +0200, Peter Eisentraut wrote: > On 21.06.18 19:30, Heikki Linnakangas wrote: >> Since this is purely a test change, IMO this could go to master now, no >> need to wait for until v12 development starts. > > I didn't want to deal with the potential for some versi

Re: location reporting in TAP test failures

2018-07-01 Thread Peter Eisentraut
On 21.06.18 19:30, Heikki Linnakangas wrote: > Looks good. I wish there was some way to remind to do this for any > future test helper functions, too, but I don't have any ideas off the > top of my head. Committed. > Since this is purely a test change, IMO this could go to master now, no > nee

Re: location reporting in TAP test failures

2018-06-21 Thread Heikki Linnakangas
On 05/06/18 18:28, Peter Eisentraut wrote: Right now, when a TAP test reports a failure, it looks something like this: # Failed test 'creating a replication slot' # at /../postgresql/src/bin/pg_basebackup/../../../src/test/perl/TestLib.pm line 371. That file location is where we cal