Re: libpq sslpassword parameter and callback function

2019-12-07 Thread Andrew Dunstan
On 12/6/19 2:57 AM, Noah Misch wrote: > On Fri, Nov 29, 2019 at 09:27:02AM -0500, Andrew Dunstan wrote: >> On 11/28/19 10:25 PM, Greg Nancarrow wrote: >>> 3) Documentation for the "PQsslpassword" function should be added to the >>> libpq "33.2 Connection Status Functions" section. >> I plan to c

Re: libpq sslpassword parameter and callback function

2019-12-05 Thread Noah Misch
On Fri, Nov 29, 2019 at 09:27:02AM -0500, Andrew Dunstan wrote: > On 11/28/19 10:25 PM, Greg Nancarrow wrote: > > 3) Documentation for the "PQsslpassword" function should be added to the > > libpq "33.2 Connection Status Functions" section. > I plan to commit this tomorrow. The PQsslpassword() f

Re: libpq sslpassword parameter and callback function

2019-11-29 Thread Andrew Dunstan
On 11/28/19 10:25 PM, Greg Nancarrow wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:tested, failed > > Hi A

Re: libpq sslpassword parameter and callback function

2019-11-28 Thread Greg Nancarrow
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, failed Hi Andrew, I've reviewed your "libpq sslpassword parameter a

Re: libpq sslpassword parameter and callback function

2019-11-27 Thread Andrew Dunstan
On 11/25/19 4:09 PM, Andrew Dunstan wrote: > On 10/31/19 7:27 PM, Andrew Dunstan wrote: >> On 10/31/19 6:34 PM, Andrew Dunstan wrote: >>> This time with attachment. >>> >>> >>> On 10/31/19 6:33 PM, Andrew Dunstan wrote: This patch provides for an sslpassword parameter for libpq, and a hook >>

Re: libpq sslpassword parameter and callback function

2019-11-25 Thread Andrew Dunstan
On 10/31/19 7:27 PM, Andrew Dunstan wrote: > On 10/31/19 6:34 PM, Andrew Dunstan wrote: >> This time with attachment. >> >> >> On 10/31/19 6:33 PM, Andrew Dunstan wrote: >>> This patch provides for an sslpassword parameter for libpq, and a hook >>> that a client can fill in for a callback function

Re: libpq sslpassword parameter and callback function

2019-11-12 Thread Bruce Momjian
On Sun, Nov 10, 2019 at 05:47:24PM +0800, Craig Ringer wrote: > Yep, that was a trivial change I rolled into it. > > FWIW, this is related to two other patches: the patch to allow passwordless > fdw > connections with explicit superuser approval, and the patch to allow sslkey/ > sslpassword to be

Re: libpq sslpassword parameter and callback function

2019-11-10 Thread Craig Ringer
On Fri, 1 Nov 2019 at 07:27, Andrew Dunstan wrote: > > On 10/31/19 6:34 PM, Andrew Dunstan wrote: > > This time with attachment. > > > > > > On 10/31/19 6:33 PM, Andrew Dunstan wrote: > >> This patch provides for an sslpassword parameter for libpq, and a hook > >> that a client can fill in for a

Re: libpq sslpassword parameter and callback function

2019-10-31 Thread Andrew Dunstan
On 10/31/19 6:34 PM, Andrew Dunstan wrote: > This time with attachment. > > > On 10/31/19 6:33 PM, Andrew Dunstan wrote: >> This patch provides for an sslpassword parameter for libpq, and a hook >> that a client can fill in for a callback function to set the password. >> >> >> This provides simil

Re: libpq sslpassword parameter and callback function

2019-10-31 Thread Andrew Dunstan
This time with attachment. On 10/31/19 6:33 PM, Andrew Dunstan wrote: > This patch provides for an sslpassword parameter for libpq, and a hook > that a client can fill in for a callback function to set the password. > > > This provides similar facilities to those already available in the JDBC >