On Tue, Jan 16, 2018 at 04:51:13PM -0300, Alvaro Herrera wrote:
> David Fetter wrote:
>
>> I'm sure I'm not alone in finding it helpful when patch sets come with
>> a single-sentence summary of the patch set and a commit message for
>> each individual patch.
>>
>> Is git format-patch really too h
On Tue, Jan 16, 2018 at 3:54 PM, Tom Lane wrote:
> FWIW, I think that that represents bad practice in those changes,
> precisely because of the hazard it poses for uncommitted patches.
> If you're changing a function signature, it's usually not that hard
> to make sure that un-updated code will pr
Peter Geoghegan writes:
> The parallel CREATE INDEX patch is something that I've worked on
> (fairly inconsistently) for 2 years now. I remember two occasions in
> which somebody else changed a function signature for functions that my
> code called, and without that causing even a compiler warning
On Tue, Jan 16, 2018 at 8:56 AM, Robert Haas wrote:
> I've seen that before as well.
>
> I have also noticed people complaining about patches that apply "with
> offsets", which also seems like needless nitpicking. If the offsets
> are large and the patch has been sitting around for a long time,
>
David Fetter wrote:
> I'm sure I'm not alone in finding it helpful when patch sets come with
> a single-sentence summary of the patch set and a commit message for
> each individual patch.
>
> Is git format-patch really too heavy a lift to ask of people?
I think it's okay as general guideline, bu
On Tue, Jan 16, 2018 at 11:56:55AM -0500, Robert Haas wrote:
> On Tue, Jan 16, 2018 at 4:04 AM, Kyotaro HORIGUCHI
> wrote:
> > At Mon, 15 Jan 2018 21:45:34 -0500, Tom Lane wrote in
> > <26718.1516070...@sss.pgh.pa.us>
> >> Robert Haas writes:
> >> > Since the "Stripping trailing CRs from patch"
On Tue, Jan 16, 2018 at 12:10 PM, Simon Riggs wrote:
> People complain... asking them not to is unlikely to get anywhere.
It doesn't hurt to ask.
> We must encourage people to speak up if they see an improvement or a
> lack of quality. I have benefited from such comments and they are not
> often
On 16 January 2018 at 16:56, Robert Haas wrote:
> On Tue, Jan 16, 2018 at 4:04 AM, Kyotaro HORIGUCHI
> wrote:
>> At Mon, 15 Jan 2018 21:45:34 -0500, Tom Lane wrote in
>> <26718.1516070...@sss.pgh.pa.us>
>>> Robert Haas writes:
>>> > Since the "Stripping trailing CRs from patch" message is tota
