On Thu, Jun 25, 2020 at 10:29 AM Daniel Gustafsson wrote:
> As this went in, can we close the 2020-07 CF entry or is there anything left
> in
> the patchseries?
Done. Thanks for the reminder.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
> On 17 Jun 2020, at 17:45, Robert Haas wrote:
>
> On Wed, Apr 29, 2020 at 5:52 AM Hamid Akhtar wrote:
>> The idea and the patch looks good to me.
>>
>> It makes sense to change fread to basebackup_read_file which internally
>> calls pg_pread which is a portable function as opposed to read. As
On Wed, Apr 29, 2020 at 5:52 AM Hamid Akhtar wrote:
> The idea and the patch looks good to me.
>
> It makes sense to change fread to basebackup_read_file which internally calls
> pg_pread which is a portable function as opposed to read. As you've
> mentioned, this is much better for error handli
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:tested, passed
The idea and the patch looks good to me.
It makes sense to chan
