Re: improve pg_receivewal code

2021-09-17 Thread Michael Paquier
On Fri, Sep 17, 2021 at 11:46:33AM +0530, Bharath Rupireddy wrote: > Thanks. I changed the code that way. PSA v3 patch. Thanks. Done. -- Michael signature.asc Description: PGP signature

Re: improve pg_receivewal code

2021-09-16 Thread Bharath Rupireddy
On Thu, Sep 16, 2021 at 9:31 AM Michael Paquier wrote: > > > Here's the v2 with above modifications. > > I was looking at this patch, and I agree that checking for the system > ID and the timeline by setting sysidentifier beforehand looks like an > improvement. > > The extra IDENTIFY_SYSTEM done a

Re: improve pg_receivewal code

2021-09-15 Thread Michael Paquier
> Here's the v2 with above modifications. I was looking at this patch, and I agree that checking for the system ID and the timeline by setting sysidentifier beforehand looks like an improvement. The extra IDENTIFY_SYSTEM done at the beginning of StreamLog() is not a performance bottleneck as we r

Re: improve pg_receivewal code

2021-09-02 Thread Bharath Rupireddy
On Thu, Sep 2, 2021 at 9:05 PM Ronan Dunklau wrote: > > 1) Fetch the server system identifier in the first RunIdentifySystem > > call and use it to identify(via pg_receivewal's ReceiveXlogStream) any > > unexpected changes that may happen in the server while pg_receivewal > > is connected to it. T

Re: improve pg_receivewal code

2021-09-02 Thread Ronan Dunklau
Le lundi 30 août 2021, 09:32:05 CEST Bharath Rupireddy a écrit : > Hi, > > I see there's a scope to do following improvements to pg_receivewal.c: Thank you Bharath for this patch. > > 1) Fetch the server system identifier in the first RunIdentifySystem > call and use it to identify(via pg_recei

Re: improve pg_receivewal code

2021-08-31 Thread Bharath Rupireddy
On Mon, Aug 30, 2021 at 1:02 PM Bharath Rupireddy wrote: > > Hi, > > I see there's a scope to do following improvements to pg_receivewal.c: > > 1) Fetch the server system identifier in the first RunIdentifySystem > call and use it to identify(via pg_receivewal's ReceiveXlogStream) any > unexpected