Re: improve CREATE EXTENSION error message

2022-01-11 Thread Bossart, Nathan
On 1/11/22, 11:23 AM, "Tom Lane" wrote: > "Bossart, Nathan" writes: >> Okay, the message looks like this in v5: > >> postgres=# CREATE EXTENSION does_not_exist; >> ERROR: extension "does_not_exist" is not available >> DETAIL: Could not open extension control file >> "/u

Re: improve CREATE EXTENSION error message

2022-01-11 Thread Tom Lane
"Bossart, Nathan" writes: > Okay, the message looks like this in v5: > postgres=# CREATE EXTENSION does_not_exist; > ERROR: extension "does_not_exist" is not available > DETAIL: Could not open extension control file > "/usr/local/pgsql/share/extension/does_not_exist.con

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Chapman Flack
On 11/29/21 17:54, Bossart, Nathan wrote: > postgres=# CREATE EXTENSION does_not_exist; > ERROR: extension "does_not_exist" is not available > DETAIL: Extension control file > "/usr/local/pgsql/share/extension/does_not_exist.control" does not exist. > HINT: The

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Bossart, Nathan
On 11/29/21, 2:32 PM, "Chapman Flack" wrote: > If it were me, I would combine that DETAIL and HINT as one larger HINT, > and use DETAIL for specific details about what actually happened (such > as the exact filename sought and the %m). > > The need for those details doesn't go away; they're still

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Tom Lane
"Bossart, Nathan" writes: > Alright, here's v3. In this version, I actually removed the message > about the control file entirely, so now the error message looks like > this: > postgres=# CREATE EXTENSION does_not_exist; > ERROR: extension "does_not_exist" is not available >

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Chapman Flack
On 11/29/21 17:13, Bossart, Nathan wrote: > postgres=# CREATE EXTENSION does_not_exist; > ERROR: extension "does_not_exist" is not available > DETAIL: The extension must first be installed on the system where > PostgreSQL is running. > HINT: The pg_available_exte

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Chapman Flack
On 11/29/21 17:03, Tom Lane wrote: > I think "The extension must ..." would read better, otherwise +1. I'm not strongly invested either way, but I'll see if I can get at why I used 'an' ... Hints are hinty. We can give them, and they're helpful, because there are certain situations that we know a

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Bossart, Nathan
On 11/29/21, 2:13 PM, "Bossart, Nathan" wrote: > Alright, here's v3. In this version, I actually removed the message > about the control file entirely, so now the error message looks like > this: > > postgres=# CREATE EXTENSION does_not_exist; > ERROR: extension "does_not_exist"

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Tom Lane
Daniel Gustafsson writes: >> On 29 Nov 2021, at 22:47, Bossart, Nathan wrote: >> On 11/29/21, 1:38 PM, "Chapman Flack" wrote: >>> Maybe a larger break with the "This means the extension something something" >>> formulation, and more on the lines of >>> HINT: an extension must first be present (

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Daniel Gustafsson
> On 29 Nov 2021, at 22:47, Bossart, Nathan wrote: > > On 11/29/21, 1:38 PM, "Chapman Flack" wrote: >> On 11/29/21 16:31, Daniel Gustafsson wrote: >>> That's a good point, the hint is targeting users who might not even know >>> that >>> an extension needs to be physically and separately install

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Bossart, Nathan
On 11/29/21, 1:38 PM, "Chapman Flack" wrote: > On 11/29/21 16:31, Daniel Gustafsson wrote: >> That's a good point, the hint is targeting users who might not even know that >> an extension needs to be physically and separately installed on the machine >> before it can be installed in their database

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Chapman Flack
On 11/29/21 16:31, Daniel Gustafsson wrote: > That's a good point, the hint is targeting users who might not even know that > an extension needs to be physically and separately installed on the machine > before it can be installed in their database; so maybe using "installed" here > isn't entirely

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Bossart, Nathan
On 11/29/21, 1:03 PM, "Tom Lane" wrote: > If we issue the hint only for errno == ENOENT, I think we could be > less wishy-washy (and if it's not ENOENT, the hint is likely > inappropriate anyway). I'm thinking something more like > > HINT: This means the extension is not installed on the system.

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Daniel Gustafsson
> On 29 Nov 2021, at 22:02, Tom Lane wrote: > > "Bossart, Nathan" writes: >> Currently, if you attempt to use CREATE EXTENSION for an extension >> that is not installed, you'll see something like the following: > >>postgres=# CREATE EXTENSION does_not_exist; >>ERROR: could not

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Bossart, Nathan
On 11/29/21, 12:33 PM, "Daniel Gustafsson" wrote: > I haven't given the suggested wording too much thought, but in general that > sounds like a good idea. Thanks. I'm flexible with the wording. Nathan

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Tom Lane
"Bossart, Nathan" writes: > Currently, if you attempt to use CREATE EXTENSION for an extension > that is not installed, you'll see something like the following: > postgres=# CREATE EXTENSION does_not_exist; > ERROR: could not open extension control file > "/usr/local/pgsql/share

Re: improve CREATE EXTENSION error message

2021-11-29 Thread Daniel Gustafsson
> On 29 Nov 2021, at 20:54, Bossart, Nathan wrote: > > Hi hackers, > > Currently, if you attempt to use CREATE EXTENSION for an extension > that is not installed, you'll see something like the following: > >postgres=# CREATE EXTENSION does_not_exist; >ERROR: could not open exte