Re: history file on replica and double switchover

2020-09-29 Thread Fujii Masao
On 2020/09/26 5:34, David Zhang wrote: The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed "make installchec

Re: history file on replica and double switchover

2020-09-25 Thread David Zhang
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed "make installcheck-world" test was performed on branch "REL_1

Re: history file on replica and double switchover

2020-09-25 Thread Fujii Masao
On 2020/09/26 2:58, Grigory Smolkin wrote: Fujii Masao, David Zhang, Anastasia Lubennikova, many thanks to you for efforts with this patch! Can I mark it as ready for committer? Ok, but I attached the updated version of the patch. It's helpful if you review that. In the latest patch, I cha

Re: history file on replica and double switchover

2020-09-25 Thread Grigory Smolkin
Fujii Masao, David Zhang, Anastasia Lubennikova, many thanks to you for efforts with this patch! Can I mark it as ready for committer? On 9/25/20 10:07 AM, Fujii Masao wrote: On 2020/09/25 13:00, David Zhang wrote: On 2020-09-24 5:00 p.m., Fujii Masao wrote: On 2020/09/25 8:15, David Zhan

Re: history file on replica and double switchover

2020-09-25 Thread Fujii Masao
On 2020/09/25 13:00, David Zhang wrote: On 2020-09-24 5:00 p.m., Fujii Masao wrote: On 2020/09/25 8:15, David Zhang wrote: Hi, My understanding is that the "archiver" won't even start if "archive_mode = on" has been set on a "replica". Therefore, either (XLogArchiveMode == ARCHIVE_MODE_AL

Re: history file on replica and double switchover

2020-09-24 Thread David Zhang
On 2020-09-24 5:00 p.m., Fujii Masao wrote: On 2020/09/25 8:15, David Zhang wrote: Hi, My understanding is that the "archiver" won't even start if "archive_mode = on" has been set on a "replica". Therefore, either (XLogArchiveMode == ARCHIVE_MODE_ALWAYS) or (XLogArchiveMode != ARCHIVE_MODE

Re: history file on replica and double switchover

2020-09-24 Thread Fujii Masao
On 2020/09/25 8:15, David Zhang wrote: Hi, My understanding is that the "archiver" won't even start if "archive_mode = on" has been set on a "replica". Therefore, either (XLogArchiveMode == ARCHIVE_MODE_ALWAYS) or (XLogArchiveMode != ARCHIVE_MODE_OFF) will produce the same result. Yes, th

Re: history file on replica and double switchover

2020-09-24 Thread David Zhang
Hi, My understanding is that the "archiver" won't even start if "archive_mode = on" has been set on a "replica". Therefore, either (XLogArchiveMode == ARCHIVE_MODE_ALWAYS) or (XLogArchiveMode != ARCHIVE_MODE_OFF) will produce the same result. Please see how the "archiver" is started in src/

Re: history file on replica and double switchover

2020-09-17 Thread Fujii Masao
On 2020/09/04 13:53, Fujii Masao wrote: On 2020/09/04 8:29, Anastasia Lubennikova wrote: On 27.08.2020 16:02, Grigory Smolkin wrote: Hello! I`ve noticed, that when running switchover replica to master and back to replica, new history file is streamed to replica, but not archived, which is

Re: history file on replica and double switchover

2020-09-03 Thread Fujii Masao
On 2020/09/04 8:29, Anastasia Lubennikova wrote: On 27.08.2020 16:02, Grigory Smolkin wrote: Hello! I`ve noticed, that when running switchover replica to master and back to replica, new history file is streamed to replica, but not archived, which is not great, because it breaks PITR if arch

Re: history file on replica and double switchover

2020-09-03 Thread Anastasia Lubennikova
On 27.08.2020 16:02, Grigory Smolkin wrote: Hello! I`ve noticed, that when running switchover replica to master and back to replica, new history file is streamed to replica, but not archived, which is not great, because it breaks PITR if archiving is running on replica. The fix looks trivial.