Re: handling multiple matching constraints in DetachPartitionFinalize()

2022-08-23 Thread Alvaro Herrera
On 2022-Aug-23, Zhihong Yu wrote: > Toggling enable_seqscan on / off using the example from `parenting a PK > constraint to a self-FK one` thread, it can be shown that different > constraint Id would be detached which is incorrect. > However, I am not sure whether toggling enable_seqscan mid-test

Re: handling multiple matching constraints in DetachPartitionFinalize()

2022-08-23 Thread Zhihong Yu
On Tue, Aug 23, 2022 at 10:53 AM Alvaro Herrera wrote: > On 2022-Aug-23, Zhihong Yu wrote: > > > This is what I came up with. > > I suggest you provide a set of SQL commands that provoke some wrong > behavior with the original code, and show that they generate good > behavior after the patch. Ot

Re: handling multiple matching constraints in DetachPartitionFinalize()

2022-08-23 Thread Alvaro Herrera
On 2022-Aug-23, Zhihong Yu wrote: > This is what I came up with. I suggest you provide a set of SQL commands that provoke some wrong behavior with the original code, and show that they generate good behavior after the patch. Otherwise, it's hard to evaluate the usefulness of this. -- Álvaro He

Re: handling multiple matching constraints in DetachPartitionFinalize()

2022-08-23 Thread Zhihong Yu
On Tue, Aug 23, 2022 at 10:10 AM Zhihong Yu wrote: > Hi, > I was looking at the following code in DetachPartitionFinalize(): > > /* If there's a constraint associated with the index, detach it > too */ > constrOid = > get_relation_idx_constraint_oid(RelationGetRelid(partRel), >