Re: gcc -ftabstop option

2022-06-23 Thread Peter Eisentraut
On 22.06.22 21:48, Daniel Gustafsson wrote: On 21 Jun 2022, at 12:49, Peter Eisentraut wrote: Second, it enables the compiler's detection of confusingly indented code to work more correctly. Wouldn't we also need to add -Wmisleading-indentation for this to trigger any warnings? That is

Re: gcc -ftabstop option

2022-06-22 Thread Daniel Gustafsson
> On 21 Jun 2022, at 12:49, Peter Eisentraut > wrote: > Second, it enables the compiler's detection of confusingly indented code to > work more correctly. Wouldn't we also need to add -Wmisleading-indentation for this to trigger any warnings? Adding -ftabstop only allows the compiler to be ab

Re: gcc -ftabstop option

2022-06-21 Thread Tom Lane
> At Tue, 21 Jun 2022 12:49:24 +0200, Peter Eisentraut > wrote in >> One bit of trickery not addressed yet is that we might want to strip >> out the option and not expose it through PGXS, since we don't know >> what whitespacing rules external code uses. This part seems like a bigger problem th

Re: gcc -ftabstop option

2022-06-21 Thread Kyotaro Horiguchi
At Tue, 21 Jun 2022 12:49:24 +0200, Peter Eisentraut wrote in > I suggest that we add the gcc (also clang) option -ftabstop=4. > > This has two effects: First, it produces more accurate column numbers > in compiler errors and correctly indents the code excerpts that the > compiler shows with th