At Wed, 22 Apr 2020 08:13:02 +0900, Michael Paquier wrote
in
> On Tue, Apr 21, 2020 at 06:09:30PM +0900, Kyotaro Horiguchi wrote:
> > At Tue, 21 Apr 2020 17:34:26 +0900, Michael Paquier
> > wrote in
> >> a checkpoint record now, but this routine could be called elsewhere in
> >> the future.
On Tue, Apr 21, 2020 at 06:09:30PM +0900, Kyotaro Horiguchi wrote:
> At Tue, 21 Apr 2020 17:34:26 +0900, Michael Paquier
> wrote in
>> a checkpoint record now, but this routine could be called elsewhere in
>> the future. Please see the attached.
>
> It looks fine to me.
Fixed this way, then.
At Tue, 21 Apr 2020 17:34:26 +0900, Michael Paquier wrote
in
> On Tue, Apr 21, 2020 at 03:08:30PM +0900, Kyotaro Horiguchi wrote:
> > The commit a7e8ece41c adds a new member restoreCommand to
> > XLogPageReadPrivate. readOneRecord doesn't make use of it but forgets
> > to set NULL. That can lead
On Tue, Apr 21, 2020 at 03:08:30PM +0900, Kyotaro Horiguchi wrote:
> The commit a7e8ece41c adds a new member restoreCommand to
> XLogPageReadPrivate. readOneRecord doesn't make use of it but forgets
> to set NULL. That can lead to illegal pointer access.
That's an oversight of the original commit.
