Re: fixing more format truncation issues

2018-03-16 Thread Peter Eisentraut
On 3/15/18 12:12, Tom Lane wrote: > FWIW, I noticed while fooling with pre-release Fedora 28 that gcc 8.0.1 > emits a whole boatload of these warnings by default. I have some patches for that. I will send them in once gcc 8 is a bit closer to release. -- Peter Eisentraut http://www

Re: fixing more format truncation issues

2018-03-15 Thread Michael Paquier
On Thu, Mar 15, 2018 at 12:12:18PM -0400, Tom Lane wrote: > FWIW, I noticed while fooling with pre-release Fedora 28 that gcc 8.0.1 > emits a whole boatload of these warnings by default. This patch doesn't > seem to have moved the needle very much, either. In a quick look, it > seemed like a lot

Re: fixing more format truncation issues

2018-03-15 Thread Tom Lane
Peter Eisentraut writes: > On 3/14/18 02:52, Michael Paquier wrote: >> Enabling them by default would generate some useless noise if the patch >> is let as-is as a couple of them are not addressed. Please see the full >> report attached. Is that intentional? I am using GCC 7.3 here. > Well tha

Re: fixing more format truncation issues

2018-03-15 Thread Peter Eisentraut
On 3/14/18 02:52, Michael Paquier wrote: > Enabling them by default would generate some useless noise if the patch > is let as-is as a couple of them are not addressed. Please see the full > report attached. Is that intentional? I am using GCC 7.3 here. Well that's weird. Apparently, the warni

Re: fixing more format truncation issues

2018-03-13 Thread Michael Paquier
On Wed, Feb 28, 2018 at 11:14:23PM -0500, Peter Eisentraut wrote: > AFAICT, the issues addressed here either can't really happen without > trying very hard, or would cause harmless output truncation. Still, it > seems good to clean this up properly and not rely on made-up buffer size > guesses tha