Re: extern keyword incorrectly used in some function definitions

2018-02-20 Thread David Rowley
On 20 February 2018 at 06:09, Tom Lane wrote: > But the rest > of these look good; pushed. Great. Thanks! -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: extern keyword incorrectly used in some function definitions

2018-02-19 Thread Tom Lane
David Rowley writes: > While poking around partition.c I noticed that one of the functions > there is *defined* as "extern". Normally we'd only do this in the > declaration of the function. I don't really see why it's needed in the > definition. > Anyway, I removed it. I then thought I'd better lo