Re: explain (verbose off, normalized) vs query planid

2018-05-15 Thread Tom Lane
Robert Haas writes: > On Tue, May 15, 2018 at 3:45 PM, legrand legrand > wrote: >> Would there be some functional or performances reasons to prefer jumbling to >> hashing normalized plan text? > Basically, I would be nervous about the idea of an EXPLAIN output > that's required to reflect all an

Re: explain (verbose off, normalized) vs query planid

2018-05-15 Thread Robert Haas
On Tue, May 15, 2018 at 3:45 PM, legrand legrand wrote: > Would there be some functional or performances reasons to prefer jumbling to > hashing normalized plan text? Using the text could produce different query IDs for the same plan if any information is displayed in the text format which can va

Re: explain (verbose off, normalized) vs query planid

2018-05-15 Thread legrand legrand
This is for tracking planid into pg_stat_statements too. A first try is available here http://www.postgresql-archive.org/Poc-pg-stat-statements-with-planid-td6014027.html reusing pg_stat_plans's "Plan tree Jumbling algorithm" from Peter Geoghegan. Hashing the normalized query plan text in one pa

Re: explain (verbose off, normalized) vs query planid

2018-05-14 Thread Robert Haas
On Sat, May 12, 2018 at 6:07 PM, legrand legrand wrote: > It seems natural (to me) to calculate a hash value based on the normalized > plan text > generated by > > explain (costs off, normalized) > or maybe > explain (costs off, verbose, normalized) I would think it would be preferable to do it b