Re: exclude tmp_check and tmp_install from pgindent

2018-10-08 Thread Tom Lane
Andrew Dunstan writes: > On 10/08/2018 09:13 AM, Michael Paquier wrote: >> I had exactly the same thought, but with "git ls-files". There are >> still some files which should not be indented, like ppport.h which is >> generated automatically still part of the tree. > That's already explicitly ex

Re: exclude tmp_check and tmp_install from pgindent

2018-10-08 Thread Andrew Dunstan
On 10/08/2018 09:13 AM, Michael Paquier wrote: On Mon, Oct 08, 2018 at 08:33:38AM -0400, Andrew Dunstan wrote: Seems reasonable - I tend to do vpath builds so this hasn't been a problem for me ;-) +1. I wonder if a more general solution might be a good idea. Say like ignoring everything po

Re: exclude tmp_check and tmp_install from pgindent

2018-10-08 Thread Tom Lane
Andrew Dunstan writes: > On 10/08/2018 05:49 AM, Peter Eisentraut wrote: >> pgindent spends a long time digging through tmp_check and tmp_install >> directories and ends up re-indenting installed header files. How about >> excluding those directories, like below or directly in the script? > I wo

Re: exclude tmp_check and tmp_install from pgindent

2018-10-08 Thread Michael Paquier
On Mon, Oct 08, 2018 at 08:33:38AM -0400, Andrew Dunstan wrote: > Seems reasonable - I tend to do vpath builds so this hasn't been a problem > for me ;-) +1. > I wonder if a more general solution might be a good idea. Say like ignoring > everything pointed to by > >     git status --porcelain --

Re: exclude tmp_check and tmp_install from pgindent

2018-10-08 Thread Andrew Dunstan
On 10/08/2018 05:49 AM, Peter Eisentraut wrote: pgindent spends a long time digging through tmp_check and tmp_install directories and ends up re-indenting installed header files. How about excluding those directories, like below or directly in the script? diff --git a/src/tools/pgindent/excl