Re: errdetail/errhint style

2022-07-19 Thread Michael Paquier
On Tue, Jul 19, 2022 at 09:51:13PM +0900, Michael Paquier wrote: > +1. I have looked at that and added the extra periods, and applied it. Thanks, Justin. -- Michael signature.asc Description: PGP signature

Re: errdetail/errhint style

2022-07-19 Thread Michael Paquier
On Tue, Jul 19, 2022 at 02:31:28PM +0200, Alvaro Herrera wrote: > Hmm, +1, though a few of these are still missing ending periods after > your patch. +1. -- Michael signature.asc Description: PGP signature

Re: errdetail/errhint style

2022-07-19 Thread Alvaro Herrera
On 2022-Jul-19, Justin Pryzby wrote: > https://www.postgresql.org/docs/current/error-style-guide.html#id-1.10.6.4.7 > > git grep 'errdetail("[[:lower:]]' > git grep 'errdetail(".*".*;' |grep -v '\."' Hmm, +1, though a few of these are still missing ending periods after your patch. -- Álvaro He