Re: ensure, not insure

2023-11-09 Thread Tom Lane
David Rowley writes: > I've pushed this. I backpatched due to the typo in the fsync GUC > description. I'd have only pushed to master if it were just the > comment typos. FTR, I do not think you should have back-patched. You created extra work for the translation team, and the mistake is subtl

Re: ensure, not insure

2023-11-09 Thread David Rowley
On Thu, 9 Nov 2023 at 14:22, Michael Paquier wrote: > > On Wed, Nov 08, 2023 at 08:31:28PM +1300, David Rowley wrote: > > Those all look fine to me too. > > +1. I've pushed this. I backpatched due to the typo in the fsync GUC description. I'd have only pushed to master if it were just the comme

Re: ensure, not insure

2023-11-08 Thread Michael Paquier
On Wed, Nov 08, 2023 at 08:31:28PM +1300, David Rowley wrote: > On Wed, 8 Nov 2023 at 19:56, Peter Smith wrote: >> In passing I found/fixed a bunch of similar misuses in comments. > > Those all look fine to me too. +1. -- Michael signature.asc Description: PGP signature

Re: ensure, not insure

2023-11-07 Thread David Rowley
On Wed, 8 Nov 2023 at 19:56, Peter Smith wrote: > gettext_noop("The server will use the fsync() system call in several > places to make " > "sure that updates are physically written to disk. This insures " > "that a database cluster will recover to a consistent state after " > "an operating