Re: eclg -C ORACLE breaks data

2023-04-19 Thread Kyotaro Horiguchi
At Thu, 20 Apr 2023 13:00:52 +0900, Michael Paquier wrote in > On Thu, Apr 20, 2023 at 12:56:32PM +0900, Kyotaro Horiguchi wrote: > > Oh, I didn't realize there were differences in the > > configurations. Good to know. > > C99 declarations are OK in v12~, so with v11 going out of sight in > app

Re: eclg -C ORACLE breaks data

2023-04-19 Thread Michael Paquier
On Thu, Apr 20, 2023 at 12:56:32PM +0900, Kyotaro Horiguchi wrote: > Oh, I didn't realize there were differences in the > configurations. Good to know. C99 declarations are OK in v12~, so with v11 going out of sight in approximately 6 month, it won't matter soon ;) -- Michael signature.asc Descr

Re: eclg -C ORACLE breaks data

2023-04-19 Thread Kyotaro Horiguchi
At Tue, 18 Apr 2023 11:35:16 +0900, Michael Paquier wrote in > On Mon, Apr 17, 2023 at 05:00:59PM +0900, Michael Paquier wrote: > > This thinko has been introduced by 3b7ab43, so this needs to go down > > to v11. I'll see to that. > > So done. mylodon is feeling unhappy about that, because th

Re: eclg -C ORACLE breaks data

2023-04-17 Thread Michael Paquier
On Mon, Apr 17, 2023 at 05:00:59PM +0900, Michael Paquier wrote: > This thinko has been introduced by 3b7ab43, so this needs to go down > to v11. I'll see to that. So done. mylodon is feeling unhappy about that, because this has a C99 declaration: https://buildfarm.postgresql.org/cgi-bin/show_lo

Re: eclg -C ORACLE breaks data

2023-04-17 Thread Kyotaro Horiguchi
(sorry for the wrong subject..) At Mon, 17 Apr 2023 17:00:59 +0900, Michael Paquier wrote in > On Mon, Apr 10, 2023 at 05:35:00PM +0900, Kyotaro Horiguchi wrote: > > This results in overwriting str[-1], the last byte of the preceding > > numeric in this case, with 0x00, representing the digit '

Re: eclg -C ORACLE breaks data

2023-04-17 Thread Michael Paquier
On Mon, Apr 10, 2023 at 05:35:00PM +0900, Kyotaro Horiguchi wrote: > This results in overwriting str[-1], the last byte of the preceding > numeric in this case, with 0x00, representing the digit '0'. When > callers of ecpg_get_data() explicitly pass zero as varcharsize, they > provide storage that