Re: dsm_registry: Add detach and destroy features

2025-03-17 Thread Sungwoo Chang
Regression test failed because I didn't add an extra new line in the expected file. 2025년 3월 17일 (월) 오전 9:55, Sungwoo Chang 님이 작성: > > There was a minor typo in the test module. I built and ran the > test_dsm_registry extension before submitting the patch but perhaps it > got mixed up with an olde

Re: dsm_registry: Add detach and destroy features

2025-03-16 Thread Sungwoo Chang
There was a minor typo in the test module. I built and ran the test_dsm_registry extension before submitting the patch but perhaps it got mixed up with an older version. From 06ddb42e39b3bd0e411a9bc96467ca6797673b8a Mon Sep 17 00:00:00 2001 From: swchangdev Date: Fri, 14 Mar 2025 10:00:12 +0900 Su

Re: dsm_registry: Add detach and destroy features

2025-03-16 Thread Sungwoo Chang
2025년 3월 14일 (금) 오후 11:36, Nathan Bossart 님이 작성: > My expectation is that the error handling takes care of these things. Are > there cases where it does not? In any case, I would expect these errors to > be extremely rare to the point of virtually never happening in practice. I don't see any log

Re: dsm_registry: Add detach and destroy features

2025-03-15 Thread Nathan Bossart
On Fri, Mar 14, 2025 at 10:46:58AM +0900, Sungwoo Chang wrote: > I also made some fix in GetNamedDSMSegment function where it throws an > exception if the found entry's size field does not match the user input. It > looks like dshash_release_lock needs to be called and MemoryContext needs > to be s