Re: dblink query interruptibility

2025-04-05 Thread Andreas Karlsson
On 4/3/25 11:29 PM, Noah Misch wrote: Pushed (e.g. v16 has commit 82a8f0f). Only v16 had libpq-be-fe-helpers.h at all, so I also back-patched 28a5917 to add it. The original use case for libpq-be-fe-helpers.h was interrupting PQconnectdbParams(), commit e460248. I decided not to back-patch tha

Re: dblink query interruptibility

2025-04-03 Thread Noah Misch
On Wed, Mar 12, 2025 at 11:03:41AM +0100, Andreas Karlsson wrote: > On 3/12/25 12:48 AM, Noah Misch wrote: > > Overall, in the absence of objections, I will queue a task to back-patch the > > non-postgres_fdw portion of commit d3c5f37 to v13-v16. Pushed (e.g. v16 has commit 82a8f0f). Only v16 had

Re: dblink query interruptibility

2025-03-12 Thread Andreas Karlsson
On 3/12/25 12:48 AM, Noah Misch wrote: The CREATE DATABASE hang is indeed new in v15. The general dblink missed interrupt processing (e.g. pg_cancel_backend response delay) is an old bug. Aha, that was what you were referring to! My apologies, was reading your mail a bit too quickly. :) Co

Re: dblink query interruptibility

2025-03-11 Thread Noah Misch
On Thu, Mar 06, 2025 at 02:57:01PM +0100, Andreas Karlsson wrote: > On 11/22/23 2:29 AM, Noah Misch wrote: > > Something as simple as the following doesn't respond to cancellation. In > > v15+, any DROP DATABASE will hang as long as it's running: > One of our customers ran into this bug when upgr

Re: dblink query interruptibility

2025-03-06 Thread Andreas Karlsson
On 11/22/23 2:29 AM, Noah Misch wrote: Something as simple as the following doesn't respond to cancellation. In v15+, any DROP DATABASE will hang as long as it's running: Hi, One of our customers ran into this bug when upgrading from PostgreSQL 14 to PostgreSQL 16. Your commit[1] fixed this

Re: dblink query interruptibility

2024-01-26 Thread Noah Misch
On Thu, Jan 25, 2024 at 12:28:43PM +0900, Fujii Masao wrote: > On Thu, Jan 25, 2024 at 5:45 AM Noah Misch wrote: > > On Thu, Jan 25, 2024 at 04:23:39AM +0900, Fujii Masao wrote: > > > I found that this patch was committed at d3c5f37dd5 and changed the > > > error message in postgres_fdw slightly.

Re: dblink query interruptibility

2024-01-24 Thread Fujii Masao
On Thu, Jan 25, 2024 at 5:45 AM Noah Misch wrote: > > On Thu, Jan 25, 2024 at 04:23:39AM +0900, Fujii Masao wrote: > > I found that this patch was committed at d3c5f37dd5 and changed the > > error message in postgres_fdw slightly. Here's an example: > > > > #1. Begin a new transaction. > > #2. Exe

Re: dblink query interruptibility

2024-01-24 Thread Noah Misch
On Thu, Jan 25, 2024 at 04:23:39AM +0900, Fujii Masao wrote: > I found that this patch was committed at d3c5f37dd5 and changed the > error message in postgres_fdw slightly. Here's an example: > > #1. Begin a new transaction. > #2. Execute a query accessing to a foreign table, like SELECT * FROM >

Re: dblink query interruptibility

2024-01-24 Thread Fujii Masao
On Wed, Nov 22, 2023 at 10:29 AM Noah Misch wrote: > > === Background > > Something as simple as the following doesn't respond to cancellation. In > v15+, any DROP DATABASE will hang as long as it's running: > > SELECT dblink_exec( > $$dbname='$$||current_database()||$$' port=$$||current_se