Re: date_trunc invalid units with infinite value

2024-12-26 Thread Michael Paquier
On Tue, Dec 24, 2024 at 04:33:47PM +0900, Michael Paquier wrote: > I am planning to get this one applied around the end of this week on > Friday for HEAD, that should be enough if there are comments and/or > objections. And done for now. If there are any remarks and/or objections, of course feel

Re: date_trunc invalid units with infinite value

2024-12-23 Thread Michael Paquier
On Thu, Dec 05, 2024 at 02:34:41PM +0900, Michael Paquier wrote: > I agree that it is inconsistent that we allow infinite values to go > through this function call even for fields that are not listed as > supported by the documentation. So, yes, I think that what you are > doing the right thing by

Re: date_trunc invalid units with infinite value

2024-12-04 Thread Michael Paquier
On Sun, Dec 01, 2024 at 03:09:17PM -0500, Joseph Koshakow wrote: > When looking at the date_trunc function, I noticed that it wasn't > rejecting invalid units if the value was infinite. It's slightly > annoying to fix this, but we already do something very similar for > date_part. I have attached a