Re: custom postgres launcher for tests

2020-03-17 Thread Ivan N. Taranov
> If we support a wrapper we should support it for all pg_ctl usage IMO. As i understand it - you propose to patch pg_ctl.c & regress.c instead of PostgresNode.pm & regress.c? This is a deeper invasion to pg_ctl. There will be a conflict between the environment variable and the pg_ctl -p parame

Re: custom postgres launcher for tests

2020-03-17 Thread Ivan N. Taranov
> If we support a wrapper we should support it for all pg_ctl usage IMO. As i understand it - you propose to patch pg_ctl.c & regress.c instead of PostgresNode.pm & regress.c? This is a deeper invasion to pg_ctl. There will be a conflict between the environment variable and the pg_ctl -p parame

Re: custom postgres launcher for tests

2020-03-10 Thread Craig Ringer
On Fri, 21 Feb 2020 at 17:05, Ivan N. Taranov wrote: > > On Fri, Feb 21, 2020 at 4:49 AM Craig Ringer wrote: > > > I thought I saw a related patch to this that proposed to add a pg_ctl > > argument. Was that you too? I can't find it at the moment. I've had it on my TODO forever but I don't think

Re: custom postgres launcher for tests

2020-02-21 Thread Ivan N. Taranov
On Fri, Feb 21, 2020 at 4:49 AM Craig Ringer wrote: > I thought I saw a related patch to this that proposed to add a pg_ctl > argument. Was that you too? I can't find it at the moment. This very simple two-line patch for src/test/perl/PostgresNode.pm code, it set `pg_ctl -p ` argument, and one-

Re: custom postgres launcher for tests

2020-02-20 Thread Craig Ringer
On Tue, 11 Feb 2020 at 19:33, Ivan Taranov wrote: > > This patch allow to use custom postgres launcher for tests (tap®ress) > by setting environment variable PGLAUNCHER. I thought I saw a related patch to this that proposed to add a pg_ctl argument. Was that you too? I can't find it at the momen