Re: create_index test fails when synchronous_commit = off @ master

2022-03-12 Thread Andres Freund
On 2022-03-11 10:38:22 +0300, Aleksander Alekseev wrote: > > Here is an updated patch that includes the commit message. > > Since this is a trivial change and no one seems to object to it so far, I'm > going to re-check the patch against the recent `master` and change its > status to "Ready for Co

Re: create_index test fails when synchronous_commit = off @ master

2022-03-10 Thread Aleksander Alekseev
Hi hackers, > Here is an updated patch that includes the commit message. Since this is a trivial change and no one seems to object to it so far, I'm going to re-check the patch against the recent `master` and change its status to "Ready for Committer" somewhere next week. -- Best regards, Aleks

Re: create_index test fails when synchronous_commit = off @ master

2022-03-02 Thread Aleksander Alekseev
Hi hackers, > I don't see what else can be done either. Here is the corresponding patch. Here is an updated patch that includes the commit message. -- Best regards, Aleksander Alekseev v2-0001-Use-synchronous_commit-on-in-test_setup.sql.patch Description: Binary data

Re: create_index test fails when synchronous_commit = off @ master

2022-02-28 Thread Aleksander Alekseev
Hi Andres, > So it might be reasonable to use synchronous_commit=on in test_setup.sql? > It's not super satisfying, but I don't immediately see what else could prevent > all-visible to be set in this case? I don't see what else can be done either. Here is the corresponding patch. -- Best regar

Re: create_index test fails when synchronous_commit = off @ master

2022-02-24 Thread Andres Freund
Hi, On 2022-02-24 07:33:39 -0800, Andres Freund wrote: > I added the SELECT relpages, reltuples, relallvisible FROM pg_class WHERE oid > = 'tenk1'::regclass; > just after the > VACUUM ANALYZE tenk1; > > synchronous_commit=on > + relpages | reltuples | relallvisible > +--+---+-

Re: create_index test fails when synchronous_commit = off @ master

2022-02-24 Thread Andres Freund
Hi, On 2022-02-24 16:47:25 +0300, Aleksander Alekseev wrote: > - QUERY PLAN > > - Index Only Scan using tenk1_thous_tenthous on tenk1 > - Index Cond: (thousand < 2) > - Filter: (tenthous = ANY ('{1001,3000}'::integer