Re: create database with template doesn't copy database ACL

2020-06-25 Thread Bruce Momjian
On Tue, Jun 16, 2020 at 06:10:54AM -0400, Bruce Momjian wrote: > On Mon, Jun 15, 2020 at 10:10:32AM -0400, Bruce Momjian wrote: > > On Mon, Jun 15, 2020 at 12:14:55AM -0400, Tom Lane wrote: > > > Bruce Momjian writes: > > > > Well, I thought we copied everything except things tha can be specified

Re: create database with template doesn't copy database ACL

2020-06-16 Thread Bruce Momjian
On Mon, Jun 15, 2020 at 10:10:32AM -0400, Bruce Momjian wrote: > On Mon, Jun 15, 2020 at 12:14:55AM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Well, I thought we copied everything except things tha can be specified > > > as different in CREATE DATABASE, though I can see why we would no

Re: create database with template doesn't copy database ACL

2020-06-15 Thread Bruce Momjian
On Mon, Jun 15, 2020 at 12:14:55AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Well, I thought we copied everything except things tha can be specified > > as different in CREATE DATABASE, though I can see why we would not copy > > them. Should we document this or issue a notice about not c

Re: create database with template doesn't copy database ACL

2020-06-14 Thread Tom Lane
Bruce Momjian writes: > Well, I thought we copied everything except things tha can be specified > as different in CREATE DATABASE, though I can see why we would not copy > them. Should we document this or issue a notice about not copying > non-default database attributes? We do not need a notice

Re: create database with template doesn't copy database ACL

2020-06-14 Thread Bruce Momjian
On Sun, Jun 14, 2020 at 11:24:56PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I am unclear if we should be copying the CONNECT and TEMPORARY > > attributes or documenting that CREATE DATABASE does not copy them. > > We should absolutely not copy them. > > As an example, it'd make sense f

Re: create database with template doesn't copy database ACL

2020-06-14 Thread Tom Lane
Bruce Momjian writes: > I am unclear if we should be copying the CONNECT and TEMPORARY > attributes or documenting that CREATE DATABASE does not copy them. We should absolutely not copy them. As an example, it'd make sense for an admin to revoke CONNECT on a template database, just to help ensur

Re: create database with template doesn't copy database ACL

2020-06-14 Thread Bruce Momjian
On Sun, Jun 14, 2020 at 07:26:13AM +, Joseph Nahmias wrote: > On Fri, Jun 12, 2020 at 05:29:51PM -0400, Bruce Momjian wrote: > > On Fri, Jun 5, 2020 at 02:31:34PM +, PG Doc comments form wrote: > > > The following documentation comment has been logged on the website: > > > > > > Page: htt