Re: cpluspluscheck vs vpath

2019-05-31 Thread Andres Freund
Hi, On 2019-05-31 09:56:45 -0400, Tom Lane wrote: > Andres Freund writes: > > Attached is a small patch allowing cpluspluscheck to run from different > > directories. I needs the src and build directories for that, > > unsurprisingly. > > No objection to changing this, but you could reduce the s

Re: cpluspluscheck vs vpath

2019-05-31 Thread Tom Lane
Andres Freund writes: > Attached is a small patch allowing cpluspluscheck to run from different > directories. I needs the src and build directories for that, > unsurprisingly. No objection to changing this, but you could reduce the surprise factor for existing workflows with a couple of defaults

Re: cpluspluscheck vs vpath

2019-05-30 Thread Alvaro Herrera
On 2019-May-30, Andres Freund wrote: > On 2019-05-30 15:02:44 -0700, Andres Freund wrote: > > > Seems we could round the edges a good bit further than what's done in > > the attached (argument checking, for example, but also using the C++ > > compiler from configure). But I think this would alread

Re: cpluspluscheck vs vpath

2019-05-30 Thread Andres Freund
Hi, On 2019-05-30 15:02:44 -0700, Andres Freund wrote: > right now cpluspluscheck doesn't work with vpath builds. That's pretty > annoying, because it does require cloning the git tree into a separate > directory + doing configure there just to run cpluspluscheck. > > Attached is a small patch al