On 28.08.24 05:31, Thomas Munro wrote:
On Wed, Jun 19, 2024 at 3:02 AM Andres Freund wrote:
-const char *EAN13_range[][2] = {
+static const char *EAN13_range[][2] = {
{"000", "019"}, /* GS1 US */
{"020", "029"}, /* Restricted distrib
On Wed, Jun 19, 2024 at 3:02 AM Andres Freund wrote:
> > -const char *EAN13_range[][2] = {
> > +static const char *EAN13_range[][2] = {
> > {"000", "019"}, /* GS1 US */
> > {"020", "029"}, /* Restricted distribution
> > (MO defined) */
>
On 03.08.24 22:46, Tom Lane wrote:
Peter Eisentraut writes:
This has all been committed now.
Various buildfarm animals are complaining about
g++ -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement
-Werror=vla -Werror=unguarded-availability-new -Wendif-labels
-Wmissing-
Peter Eisentraut writes:
> This has all been committed now.
Various buildfarm animals are complaining about
g++ -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement
-Werror=vla -Werror=unguarded-availability-new -Wendif-labels
-Wmissing-format-attribute -Wcast-function-type
On 26.07.24 11:07, Peter Eisentraut wrote:
I have committed all of the fixes that I had previously posted, but
before actually activating the warning option, I found another small
hiccup with the Bison files.
This has all been committed now.
I have committed all of the fixes that I had previously posted, but
before actually activating the warning option, I found another small
hiccup with the Bison files.
Before Bison 3.4, the generated parser implementation files run afoul of
-Wmissing-variable-declarations (in spite of commit ab6
I have committed the first few of these. (The compiler warning flag
itself is not activated yet.) This should allow you to proceed with
your patches that add various const qualifiers. I'll come back to the
rest later.
On 18.06.24 17:02, Andres Freund wrote:
diff --git a/src/bin/pg_archive
Hi,
+many for doing this in principle
> -const char *EAN13_range[][2] = {
> +static const char *EAN13_range[][2] = {
> {"000", "019"}, /* GS1 US */
> {"020", "029"}, /* Restricted distribution (MO
> defined) */
> {"030", "039"},
Here is an updated patch set. I have implemented proper solutions for
the various hacks in the previous patch set. So this patch set should
now be ready for proper consideration.
The way I have organized it here is that patches 0002 through 0008
should be improvements in their own right.
T
On 10.05.24 11:53, Heikki Linnakangas wrote:
On 09/05/2024 12:23, Peter Eisentraut wrote:
In [0] I had noticed that we have no automated verification that global
variables are declared in header files. (For global functions, we have
this through -Wmissing-prototypes.) As I mentioned there, I d
On 09/05/2024 12:23, Peter Eisentraut wrote:
In [0] I had noticed that we have no automated verification that global
variables are declared in header files. (For global functions, we have
this through -Wmissing-prototypes.) As I mentioned there, I discovered
the Clang compiler option -Wmissing-
11 matches
Mail list logo
