On Wed, Apr 01, 2020 at 03:52:17PM +0200, Peter Eisentraut wrote:
> On 2020-03-30 10:08, Michael Paquier wrote:
>> Cannot you add a link to the page for color support in each one of
>> them? That seems more user-friendly to me.
>
> Do you have a specific phrasing or look in mind?
I actually do.
On 2020-03-30 10:08, Michael Paquier wrote:
On Sun, Mar 29, 2020 at 11:56:15AM +0200, Peter Eisentraut wrote:
I didn't do this because it would create additional complications in the man
pages. But there is now an index entry, so it's possible to find more
information.
Cannot you add a link t
On 2020-03-30 10:03, Michael Paquier wrote:
On Sun, Mar 29, 2020 at 02:55:37PM +0200, Juan José Santamaría Flecha wrote:
Add it to the tests done when PG_COLOR is "auto".
FWIW, I am not sure that it is a good idea to stick into the code
knowledge inherent to TERM. That would likely rot depend
On Sun, Mar 29, 2020 at 11:56:15AM +0200, Peter Eisentraut wrote:
> I didn't do this because it would create additional complications in the man
> pages. But there is now an index entry, so it's possible to find more
> information.
Cannot you add a link to the page for color support in each one o
On Sun, Mar 29, 2020 at 02:55:37PM +0200, Juan José Santamaría Flecha wrote:
> Add it to the tests done when PG_COLOR is "auto".
FWIW, I am not sure that it is a good idea to stick into the code
knowledge inherent to TERM. That would likely rot depending on how
terminals evolve in the future, and
On Sun, Mar 29, 2020 at 11:56 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2020-03-24 15:34, Juan José Santamaría Flecha wrote:
> > I think there is also some value in adding the functionality proposed in
> > terminal_supports_color().
>
> What do you want to do with that fu
On 2020-03-24 15:34, Juan José Santamaría Flecha wrote:
I think there is also some value in adding the functionality proposed in
terminal_supports_color().
What do you want to do with that functionality?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7
On 2020-03-26 07:36, Michael Paquier wrote:
I am not sure that deleting all the mentions would be a good idea, as
we'd lose track of which tool supports coloring or not, and that could
confuse users. What about switching the existing paragraph to a
simple sentence with a link to the new appendix
On Mon, Mar 23, 2020 at 09:32:08AM +0100, Peter Eisentraut wrote:
> Attached is the documentation patch reworked.
Thanks!
> Should we delete all the repetitive mentions on the man pages?
I am not sure that deleting all the mentions would be a good idea, as
we'd lose track of which tool supports
On Mon, Mar 23, 2020 at 9:32 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
>
> I'm giving up on making color the default, since there is clearly no
> consensus.
>
> Attached is the documentation patch reworked.
>
I think there is also some value in adding the functionality propos
On 2020-03-23 06:04, Michael Paquier wrote:
On Fri, Mar 20, 2020 at 11:22:07PM -0400, Bruce Momjian wrote:
On Fri, Mar 20, 2020 at 11:15:07PM -0400, Tom Lane wrote:
Yeah, but the point is precisely that pg_logging_init()
also responds to PG_COLORS, which is not documented anywhere.
Oh, I thou
On Fri, Mar 20, 2020 at 11:22:07PM -0400, Bruce Momjian wrote:
> On Fri, Mar 20, 2020 at 11:15:07PM -0400, Tom Lane wrote:
>> Yeah, but the point is precisely that pg_logging_init()
>> also responds to PG_COLORS, which is not documented anywhere.
>
> Oh, I thought it was a typo. OK, so it still a
On Sat, 21 Mar 2020 at 00:25, Jonah H. Harris
wrote:
> On Tue, Dec 31, 2019 at 8:35 AM Tom Lane wrote:
>
>> Peter Eisentraut writes:
>> > With the attached patch, I propose to enable the colored output by
>> > default in PG13.
>>
>> FWIW, I shall be setting NO_COLOR permanently if this gets com
On Tue, Dec 31, 2019 at 8:35 AM Tom Lane wrote:
> Peter Eisentraut writes:
> > With the attached patch, I propose to enable the colored output by
> > default in PG13.
>
> FWIW, I shall be setting NO_COLOR permanently if this gets committed.
> I wonder how many people there are who actually *like
On Fri, Mar 20, 2020 at 11:15:07PM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> >> I can confirm there is still no mention of PG_COLORS in our
> >> documentation.
>
> > My mistake, PG_COLOR (not PG_COLORS) is documented properly.
>
> Yeah, but the point is precisely that pg_logging_init()
>
Bruce Momjian writes:
>> I can confirm there is still no mention of PG_COLORS in our
>> documentation.
> My mistake, PG_COLOR (not PG_COLORS) is documented properly.
Yeah, but the point is precisely that pg_logging_init()
also responds to PG_COLORS, which is not documented anywhere.
On Thu, Mar 19, 2020 at 10:15:57PM -0400, Bruce Momjian wrote:
> On Tue, Mar 3, 2020 at 02:31:01PM +0900, Michael Paquier wrote:
> > On Mon, Mar 02, 2020 at 01:00:44PM +0100, Juan José Santamaría Flecha wrote:
> > > - The new entry in the documentation, specially as the PG_COLORS parameter
> > > s
On Tue, Mar 3, 2020 at 02:31:01PM +0900, Michael Paquier wrote:
> On Mon, Mar 02, 2020 at 01:00:44PM +0100, Juan José Santamaría Flecha wrote:
> > - The new entry in the documentation, specially as the PG_COLORS parameter
> > seems to be currently undocumented. The programs that can use PG_COLOR
>
On Mon, Mar 02, 2020 at 01:00:44PM +0100, Juan José Santamaría Flecha wrote:
> - The new entry in the documentation, specially as the PG_COLORS parameter
> seems to be currently undocumented. The programs that can use PG_COLOR
> would benefit from getting a link to it.
The actual problem here is t
The patch to improve color support on Windows has been commited [1], and I
would like to share some of the discussion there that might affect this
patch.
- The documentation/comments could make a better job of explaining the case
of PG_COLOR equals 'always', explicitly saying that no checks are do
On 06/01/2020 18:38, Michael Paquier wrote:
On Fri, Jan 03, 2020 at 01:10:30PM -0500, Robert Haas wrote:
On Thu, Jan 2, 2020 at 6:38 PM Gavin Flower
wrote:
I find coloured output very difficult to read, as the colours seem to be
chosen on the basis everyone uses white as the background colour
On Fri, Jan 03, 2020 at 01:10:30PM -0500, Robert Haas wrote:
> On Thu, Jan 2, 2020 at 6:38 PM Gavin Flower
> wrote:
>> I find coloured output very difficult to read, as the colours seem to be
>> chosen on the basis everyone uses white as the background colour for
>> terminals -- whereas I use blac
On Tue, Dec 31, 2019 at 8:35 AM Tom Lane wrote:
> Peter Eisentraut writes:
> > With the attached patch, I propose to enable the colored output by
> > default in PG13.
>
> FWIW, I shall be setting NO_COLOR permanently if this gets committed.
> I wonder how many people there are who actually *like
On Thu, Jan 2, 2020 at 6:38 PM Gavin Flower
wrote:
> I find coloured output very difficult to read, as the colours seem to be
> chosen on the basis everyone uses white as the background colour for
> terminals -- whereas I use black, as do a lot of other people.
I don't like colored output either.
On 01/01/2020 02:35, Tom Lane wrote:
Peter Eisentraut writes:
With the attached patch, I propose to enable the colored output by
default in PG13.
FWIW, I shall be setting NO_COLOR permanently if this gets committed.
I wonder how many people there are who actually *like* colored output?
I find
On 31/12/19 14:35, Tom Lane wrote:
Peter Eisentraut writes:
With the attached patch, I propose to enable the colored output by
default in PG13.
FWIW, I shall be setting NO_COLOR permanently if this gets committed.
I wonder how many people there are who actually *like* colored output?
I find it
On Tue, 31 Dec 2019 at 10:18, Alvaro Herrera
wrote:
Per https://no-colors.org (thanks for the link) it seems pretty clear
>
https://no-color.org
On 2019-Dec-31, Andreas Joseph Krogh wrote:
> It's easier to spot errors/warnings when they are colored/emphasized imo.
> Much
> like colored output from grep/diff; We humans have colored vision for a
> reason.
I do use color output (and find it useful), for that reason.
I'm not sure that th
På tirsdag 31. desember 2019 kl. 14:35:39, skrev Tom Lane mailto:t...@sss.pgh.pa.us>>:
Peter Eisentraut writes:
> With the attached patch, I propose to enable the colored output by
> default in PG13.
FWIW, I shall be setting NO_COLOR permanently if this gets committed.
I wonder how many peo
> On 31 Dec 2019, at 14:35, Tom Lane wrote:
>
> Peter Eisentraut writes:
>> With the attached patch, I propose to enable the colored output by
>> default in PG13.
>
> FWIW, I shall be setting NO_COLOR permanently if this gets committed.
Me too.
> I may well be in the minority, but I think so
On Tue, Dec 31, 2019 at 7:35 AM Tom Lane wrote:
> Peter Eisentraut writes:
> > With the attached patch, I propose to enable the colored output by
> > default in PG13.
>
> FWIW, I shall be setting NO_COLOR permanently if this gets committed.
> I wonder how many people there are who actually *like
Peter Eisentraut writes:
> With the attached patch, I propose to enable the colored output by
> default in PG13.
FWIW, I shall be setting NO_COLOR permanently if this gets committed.
I wonder how many people there are who actually *like* colored output?
I find it to be invariably less readable t
On Tue, Dec 31, 2019 at 11:40 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
>
> I'm aware of the pending patch to improve color support on Windows.
> I'll check that one out as well, but it appears to be orthogonal to this
> one.
>
>
Actually I think it would be better to rebase t
33 matches
Mail list logo
