Re: cleaning up a few CLOG-related things

2021-03-21 Thread Noah Misch
On Wed, Jan 27, 2021 at 12:35:30PM -0500, Robert Haas wrote: > On Mon, Jan 25, 2021 at 2:11 PM Heikki Linnakangas wrote: > > Having a separate FullTransactionIdToLatestPageNumber() function for > > this seems like overkill to me. > > I initially thought so too, but it turned out to be pretty usef

Re: cleaning up a few CLOG-related things

2021-01-27 Thread Robert Haas
On Mon, Jan 25, 2021 at 2:11 PM Heikki Linnakangas wrote: > > [patches 0001 - 0003] > > Makes sense. Great. I committed the first one and will proceed with those as well. > > So, the CLOG page gets created when nextXid advances from the first > > value on the page to the second value on the page

Re: cleaning up a few CLOG-related things

2021-01-25 Thread Heikki Linnakangas
On 25/01/2021 18:56, Robert Haas wrote: I attach a series of proposed patches to slightly improve some minor things related to the CLOG code. [patches 0001 - 0003] Makes sense. 0004 - In StartupCLOG(), correct an off-by-one error. Currently, if the nextXid is exactly a multiple of the number