On 7/18/21 11:48 AM, Andrew Dunstan wrote:
> On 7/16/21 3:32 PM, Andrew Dunstan wrote:
>> On 6/28/21 1:02 PM, Andrew Dunstan wrote:
>>> On 4/24/21 3:14 PM, Alvaro Herrera wrote:
On 2021-Apr-24, Andrew Dunstan wrote:
> I would like to undertake some housekeeping on PostgresNode.pm.
>>
On 7/16/21 3:32 PM, Andrew Dunstan wrote:
> On 6/28/21 1:02 PM, Andrew Dunstan wrote:
>> On 4/24/21 3:14 PM, Alvaro Herrera wrote:
>>> On 2021-Apr-24, Andrew Dunstan wrote:
>>>
I would like to undertake some housekeeping on PostgresNode.pm.
1. OO modules in perl typically don't expo
On 6/28/21 1:02 PM, Andrew Dunstan wrote:
> On 4/24/21 3:14 PM, Alvaro Herrera wrote:
>> On 2021-Apr-24, Andrew Dunstan wrote:
>>
>>> I would like to undertake some housekeeping on PostgresNode.pm.
>>>
>>> 1. OO modules in perl typically don't export anything. We should remove
>>> the export setti
On 6/30/21 8:30 AM, Alvaro Herrera wrote:
> On 2021-Jun-30, Andrew Dunstan wrote:
>
>> On 6/30/21 12:35 AM, Michael Paquier wrote:
>>> On Mon, Jun 28, 2021 at 01:02:37PM -0400, Andrew Dunstan wrote:
>>> skip_equals is not used. The only caller of adjust_conf is
>>> PostgresNode itself.
>> Well,
On 2021-Jun-30, Andrew Dunstan wrote:
> On 6/30/21 12:35 AM, Michael Paquier wrote:
> > On Mon, Jun 28, 2021 at 01:02:37PM -0400, Andrew Dunstan wrote:
> > skip_equals is not used. The only caller of adjust_conf is
> > PostgresNode itself.
>
> Well, nothing is using it right now :-) It's intend
On 6/30/21 12:35 AM, Michael Paquier wrote:
> On Mon, Jun 28, 2021 at 01:02:37PM -0400, Andrew Dunstan wrote:
>> Patch 1 adds back the '-w' flag to pg_ctl in the start() method. It's
>> redundant on modern versions of Postgres but it's harmless, and helps
>> with subclassing for older versions wh
On Mon, Jun 28, 2021 at 01:02:37PM -0400, Andrew Dunstan wrote:
> Patch 1 adds back the '-w' flag to pg_ctl in the start() method. It's
> redundant on modern versions of Postgres but it's harmless, and helps
> with subclassing for older versions where it wasn't the default.
05cd12e applied to all
On 4/24/21 3:14 PM, Alvaro Herrera wrote:
> On 2021-Apr-24, Andrew Dunstan wrote:
>
>> I would like to undertake some housekeeping on PostgresNode.pm.
>>
>> 1. OO modules in perl typically don't export anything. We should remove
>> the export settings. That would mean that clients would have to ca
On 2021-Apr-24, Andrew Dunstan wrote:
>
> I would like to undertake some housekeeping on PostgresNode.pm.
>
> 1. OO modules in perl typically don't export anything. We should remove
> the export settings. That would mean that clients would have to call
> "PostgresNode->get_new_node()" (but see i
