On 2019-08-12 20:17, Tom Lane wrote:
> Peter Eisentraut writes:
>> OK, let's do it like that. Updated patch attached.
>
> LGTM, but I don't have the ability to test it on Windows.
Committed, after some testing on Windows.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL
Peter Eisentraut writes:
> OK, let's do it like that. Updated patch attached.
LGTM, but I don't have the ability to test it on Windows.
regards, tom lane
On 2019-08-08 17:51, Tom Lane wrote:
> However, I don't much like the choice to set LC_COLLATE and LC_CTYPE
> differently. That seems to be risking weird behavior, and for what?
> I'd be inclined to just remove the WIN32 stanza, initialize all
> three of these variables with "", and explain it alo
I wrote:
> ... In particular, I'm concerned that this patch will
> result in subtle changes in what settings get chosen during initdb.
OK, after reviewing the code a bit more I take that back --- initdb's
choices are entirely made within initdb.
However, I don't much like the choice to set LC_COL
Peter Eisentraut writes:
> A long time ago, we changed LC_COLLATE and LC_CTYPE from cluster-wide to
> per-database (61d967498802ab86d8897cb3c61740d7e9d712f6). There is some
> leftover code from that in initdb.c and backend/main/main.c to pass
> these environment variables around in the expectatio