Re: ci: Allow running mingw tests by default via environment variable

2025-04-14 Thread Nathan Bossart
On Mon, Apr 14, 2025 at 09:26:59PM +0200, Andres Freund wrote: > On April 14, 2025 9:22:40 PM GMT+02:00, Nathan Bossart > wrote: >>On Sat, Apr 12, 2025 at 08:18:35PM +1200, Thomas Munro wrote: >>> Is it safe to assume that CI changes come under the same code-freeze >>> exception as tests and docs

Re: ci: Allow running mingw tests by default via environment variable

2025-04-14 Thread Andres Freund
Hi, On April 14, 2025 9:22:40 PM GMT+02:00, Nathan Bossart wrote: >On Sat, Apr 12, 2025 at 08:18:35PM +1200, Thomas Munro wrote: >> Is it safe to assume that CI changes come under the same code-freeze >> exception as tests and docs? I would assume so, it's just scripting >> glue in .cirrus.XXX

Re: ci: Allow running mingw tests by default via environment variable

2025-04-14 Thread Nathan Bossart
On Sat, Apr 12, 2025 at 08:18:35PM +1200, Thomas Munro wrote: > Is it safe to assume that CI changes come under the same code-freeze > exception as tests and docs? I would assume so, it's just scripting > glue in .cirrus.XXX files not affecting one bit of the software, but I > don't recall that we

Re: ci: Allow running mingw tests by default via environment variable

2025-04-12 Thread Thomas Munro
On Tue, Apr 8, 2025 at 1:43 AM Andres Freund wrote: > On 2025-04-07 16:03:48 +0300, Nazir Bilal Yavuz wrote: > > On Wed, 5 Mar 2025 at 18:51, Andres Freund wrote: > > > I'm inclined to think we should apply to this to all branches with CI > > > support, > > > not just master. It's kind of annoyi

Re: ci: Allow running mingw tests by default via environment variable

2025-04-07 Thread Andres Freund
Hi, On 2025-04-07 16:03:48 +0300, Nazir Bilal Yavuz wrote: > On Wed, 5 Mar 2025 at 18:51, Andres Freund wrote: > > I'm inclined to think we should apply to this to all branches with CI > > support, > > not just master. It's kind of annoying to have CI infrastructure changes > > like > > this t

Re: ci: Allow running mingw tests by default via environment variable

2025-04-07 Thread Nazir Bilal Yavuz
Hi, On Wed, 5 Mar 2025 at 18:51, Andres Freund wrote: > > Hi, > > I'm inclined to think we should apply to this to all branches with CI support, > not just master. It's kind of annoying to have CI infrastructure changes like > this that differ between branches. Thoughts? I am sharing patches pe

Re: ci: Allow running mingw tests by default via environment variable

2025-03-05 Thread Andres Freund
Hi, I'm inclined to think we should apply to this to all branches with CI support, not just master. It's kind of annoying to have CI infrastructure changes like this that differ between branches. Thoughts? Greetings, Andres Freund

Re: ci: Allow running mingw tests by default via environment variable

2025-03-04 Thread Andres Freund
Hi, On 2025-03-04 11:53:30 +0300, Nazir Bilal Yavuz wrote: > I rebased Andres' v2-0002 on top of recent changes and wrote a small > commit message. v4 is attached. Thanks for doing that, it does look a lot better after, I think! Greetings, Andres Freund

Re: ci: Allow running mingw tests by default via environment variable

2025-03-04 Thread Andres Freund
Hi, On 2025-03-04 13:27:29 +1300, Thomas Munro wrote: > On Fri, Apr 26, 2024 at 12:02 AM Nazir Bilal Yavuz wrote: > > On Sat, 13 Apr 2024 at 05:12, Andres Freund wrote: > > > I propose that we instead run the task automatically if > > > $REPO_MINGW_TRIGGER_BY_DEFAULT is set, typically in cirrus'

Re: ci: Allow running mingw tests by default via environment variable

2025-03-04 Thread Nazir Bilal Yavuz
Hi, On Tue, 4 Mar 2025 at 03:28, Thomas Munro wrote: > > On Fri, Apr 26, 2024 at 12:02 AM Nazir Bilal Yavuz wrote: > > On Sat, 13 Apr 2024 at 05:12, Andres Freund wrote: > > > I propose that we instead run the task automatically if > > > $REPO_MINGW_TRIGGER_BY_DEFAULT is set, typically in cirru

Re: ci: Allow running mingw tests by default via environment variable

2025-03-03 Thread Thomas Munro
On Fri, Apr 26, 2024 at 12:02 AM Nazir Bilal Yavuz wrote: > On Sat, 13 Apr 2024 at 05:12, Andres Freund wrote: > > I propose that we instead run the task automatically if > > $REPO_MINGW_TRIGGER_BY_DEFAULT is set, typically in cirrus' per-repository > > configuration. > > > > Unfortunately that's

Re: ci: Allow running mingw tests by default via environment variable

2024-04-25 Thread Nazir Bilal Yavuz
Hi, Thank you for working on this! On Sat, 13 Apr 2024 at 05:12, Andres Freund wrote: > > Hi, > > We have CI support for mingw, but don't run the task by default, as it eats up > precious CI credits. However, for cfbot we are using custom compute resources > (currently donated by google), so we