Re: cfbot update: Using GitHub for patch review

2024-07-01 Thread Ashutosh Bapat
On Sat, Jun 29, 2024 at 2:12 PM Jelte Fennema-Nio wrote: > On Sat, 29 Jun 2024 at 01:13, Thomas Munro wrote: > > > > On Sat, Jun 29, 2024 at 1:10 AM Ashutosh Bapat > > wrote: > > > I need to sign in to github to add my review comments. So those who do > not have a github account can not use it

Re: cfbot update: Using GitHub for patch review

2024-06-29 Thread Jelte Fennema-Nio
On Sat, 29 Jun 2024 at 01:13, Thomas Munro wrote: > > On Sat, Jun 29, 2024 at 1:10 AM Ashutosh Bapat > wrote: > > I need to sign in to github to add my review comments. So those who do not > > have a github account can not use it for review. But I don't think that can > > be fixed. We need a wa

Re: cfbot update: Using GitHub for patch review

2024-06-28 Thread Thomas Munro
On Sat, Jun 29, 2024 at 1:10 AM Ashutosh Bapat wrote: > I need to sign in to github to add my review comments. So those who do not > have a github account can not use it for review. But I don't think that can > be fixed. We need a way to know who left review comments. I don't think Jelte was ta

Re: cfbot update: Using GitHub for patch review

2024-06-28 Thread Ashutosh Bapat
On Fri, Jun 21, 2024 at 8:06 PM Jelte Fennema-Nio wrote: > I recently got write access to the cfbot repo[1] and machine from > Thomas. And I deployed a few improvements this week. The most > significant one is that it is now much easier to use GitHub as part of > your patch review workflow. > > O

Re: cfbot update: Using GitHub for patch review

2024-06-21 Thread Pavel Stehule
pá 21. 6. 2024 v 17:55 odesílatel Nathan Bossart napsal: > On Fri, Jun 21, 2024 at 04:36:13PM +0200, Jelte Fennema-Nio wrote: > > I recently got write access to the cfbot repo[1] and machine from > > Thomas. And I deployed a few improvements this week. The most > > significant one is that it is n

Re: cfbot update: Using GitHub for patch review

2024-06-21 Thread Josef Šimánek
pá 21. 6. 2024 v 16:36 odesílatel Jelte Fennema-Nio napsal: > > I recently got write access to the cfbot repo[1] and machine from > Thomas. And I deployed a few improvements this week. The most > significant one is that it is now much easier to use GitHub as part of > your patch review workflow. >

Re: cfbot update: Using GitHub for patch review

2024-06-21 Thread Nathan Bossart
On Fri, Jun 21, 2024 at 04:36:13PM +0200, Jelte Fennema-Nio wrote: > I recently got write access to the cfbot repo[1] and machine from > Thomas. And I deployed a few improvements this week. The most > significant one is that it is now much easier to use GitHub as part of > your patch review workflo