Re: basebackup/lz4 crash

2022-04-04 Thread Robert Haas
On Thu, Mar 31, 2022 at 3:19 AM Dipesh Pandit wrote: > Patch attached. Committed. Thanks. -- Robert Haas EDB: http://www.enterprisedb.com

Re: basebackup/lz4 crash

2022-03-31 Thread Dipesh Pandit
Hi, > I think your proposed change is OK, modulo some comments. But I think > maybe we ought to delete all the stuff related to compressed_bound > from bbstreamer_lz4_compressor_new() as well, because I don't see that > there's any point. And then I think we should also add logic similar > to what

Re: basebackup/lz4 crash

2022-03-30 Thread Robert Haas
On Wed, Mar 30, 2022 at 10:35 AM Justin Pryzby wrote: > It looks like maybe this code was copied from > bbstreamer_lz4_compressor_finalize() which has an Assert rather than expanding > the buffer like in bbstreamer_lz4_compressor_new() Hmm, this isn't great. On the server side, we set up a chain