Re: allow trigger to get updated columns

2025-01-21 Thread Tom Lane
I wrote: > If this is not in fact completely broken, the reason must be that > ats_modifiedcols will always be the same for the same values of > ats_tgoid/ats_relid/ats_event/ats_table (within a given transaction). > That seems unlikely, Indeed, it's false. I was able to make a test case demonstr

Re: allow trigger to get updated columns

2025-01-21 Thread Tom Lane
Peter Eisentraut writes: > On 2020-03-05 13:53, Daniel Gustafsson wrote: >> +1 on the patchset, marking this entry as Ready For Committer. > and done While looking at a pending patch, I happened to notice that commit 71d60e2aa added a field ats_modifiedcols to AfterTriggerSharedData, but did not

Re: allow trigger to get updated columns

2020-03-09 Thread Peter Eisentraut
On 2020-03-05 13:53, Daniel Gustafsson wrote: The 0001 refactoring patch seems a clear win to me. In the 0002 patch: +For UPDATE triggers, a bitmap set indicating the +columns that were updated by the triggering command. Generic trigger Is it worth pointing out that tg_updated

Re: allow trigger to get updated columns

2020-03-05 Thread Daniel Gustafsson
> On 24 Feb 2020, at 10:58, Peter Eisentraut > wrote: > > This is a change to make the bitmap of updated columns available to a trigger > in TriggerData. This is the same idea as was recently done to generated > columns [0]: Generic triggers such as tsvector_update_trigger can use this > inf