Alvaro Herrera writes:
>> I can get behind that ... it makes the patch a lot smaller.
> Here it is.
LGTM.
> I noticed that ECPG's copy was setting errno. I had forgot to do that
> in my previous patch, but on second look, malloc failure already sets
> it, so doing it again is pointless.
Right
On 2019-Dec-04, Alvaro Herrera wrote:
> On 2019-Dec-04, Tom Lane wrote:
>
> > Andres Freund writes:
> > > On 2019-12-04 11:40:21 -0300, Alvaro Herrera wrote:
> > >> I think this should be pretty uncontroversial, but wanted to give a
> > >> heads-up outside that thread. I attach the patch here f
On 2019-Dec-04, Tom Lane wrote:
> Andres Freund writes:
> > On 2019-12-04 11:40:21 -0300, Alvaro Herrera wrote:
> >> I think this should be pretty uncontroversial, but wanted to give a
> >> heads-up outside that thread. I attach the patch here for completeness.
>
> > I'd just provide pnstrdup()
Andres Freund writes:
> On 2019-12-04 11:40:21 -0300, Alvaro Herrera wrote:
>> I think this should be pretty uncontroversial, but wanted to give a
>> heads-up outside that thread. I attach the patch here for completeness.
> I'd just provide pnstrdup() in the frontend, without adding strndup().
Hi,
On 2019-12-04 11:40:21 -0300, Alvaro Herrera wrote:
> I just proposed in
> https://postgr.es/m/0191204143715.GA17312@alvherre.pgsql the addition of
> strndup() to our src/port.
>
> I think this should be pretty uncontroversial, but wanted to give a
> heads-up outside that thread. I attach th
Alvaro Herrera writes:
> I just proposed in
> https://postgr.es/m/0191204143715.GA17312@alvherre.pgsql the addition of
> strndup() to our src/port.
> I think this should be pretty uncontroversial, but wanted to give a
> heads-up outside that thread. I attach the patch here for completeness.
Grep
