On 2025-May-12, Fujii Masao wrote:
> I have no objection to this commit. However, I had assumed we would
> wait to commit changes like this - which aren't bug fixes or
> v18-related oversights - until master becomes the development branch
> for v19. Maybe I'm missing something..
Yeah, fair questi
Fujii Masao writes:
> On 2025/05/11 23:22, Álvaro Herrera wrote:
>> Done that, and pushed.
> I have no objection to this commit. However, I had assumed we would
> wait to commit changes like this - which aren't bug fixes or
> v18-related oversights - until master becomes the development branch
>
On 2025/05/11 23:22, Álvaro Herrera wrote:
On 2025-Apr-29, Dagfinn Ilmari Mannsåker wrote:
jian he writes:
+ /* ALTER DOMAIN ADD */
+ else if (Matches("ALTER", "DOMAIN", MatchAny, "ADD"))
+ COMPLETE_WITH("CONSTRAINT", "NOT NULL", "CHECK");
I think the complet
On Sun, 11 May 2025, at 15:48, Álvaro Herrera wrote:
> So we should also have tab-completion for ALTER TABLE ADD NOT NULL, as
> in the attached. Any opinions?
LGTM
--
- ilmari
So we should also have tab-completion for ALTER TABLE ADD NOT NULL, as
in the attached. Any opinions?
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Estoy de acuerdo contigo en que la verdad absoluta no existe...
El problema es que la mentira sí existe y tu est
On 2025-Apr-29, Dagfinn Ilmari Mannsåker wrote:
> jian he writes:
> > + /* ALTER DOMAIN ADD */
> > + else if (Matches("ALTER", "DOMAIN", MatchAny, "ADD"))
> > + COMPLETE_WITH("CONSTRAINT", "NOT NULL", "CHECK");
>
> I think the completion for CHECK should include the opening paren
jian he writes:
> hi.
>
> per https://www.postgresql.org/docs/current/sql-alterdomain.html
>
> we can add tab-complete for ALTER DOMAIN ADD variants:
> ALTER DOMAIN sth ADD CHECK
> ALTER DOMAIN sth ADD CONSTRAINT
> ALTER DOMAIN sth ADD NOT NULL
Good catch.
> + /* ALTER DOMAIN ADD */
> +
