Re: a thinko in b676ac443b6

2021-07-28 Thread Tomas Vondra
On 7/28/21 3:15 AM, Amit Langote wrote: > On Wed, Jul 28, 2021 at 1:07 AM Tomas Vondra > wrote: >> On 7/27/21 4:28 AM, Amit Langote wrote: >>> I think it can be incorrect to use the same TupleDesc for both the >>> slots in ri_Slots (for ready-to-be-inserted tuples) and ri_PlanSlots >>> (for subpla

Re: a thinko in b676ac443b6

2021-07-27 Thread Amit Langote
On Wed, Jul 28, 2021 at 1:07 AM Tomas Vondra wrote: > On 7/27/21 4:28 AM, Amit Langote wrote: > > I think it can be incorrect to use the same TupleDesc for both the > > slots in ri_Slots (for ready-to-be-inserted tuples) and ri_PlanSlots > > (for subplan output tuples). Especially if you consider

Re: a thinko in b676ac443b6

2021-07-27 Thread Tomas Vondra
On 7/27/21 4:28 AM, Amit Langote wrote: > Hi, > > I noticed $subject while rebasing my patch at [1] to enable batching > for the inserts used in cross-partition UPDATEs. > > b676ac443b6 did this: > > - resultRelInfo->ri_PlanSlots[resultRelInfo->ri_NumSlots] = > - MakeSing