Re: Why don't update minimum recovery point in xact_redo_abort

2021-07-28 Thread Fujii Masao
On 2021/07/28 12:44, Fujii Masao wrote: On 2021/07/28 6:25, Heikki Linnakangas wrote: On 27/07/2021 19:49, Fujii Masao wrote: Anyway I attached the patch that changes only xact_redo_abort() so that it calls XLogFlush() to update min recovery point. Looks good to me, thanks! FWIW, I used

Re: Why don't update minimum recovery point in xact_redo_abort

2021-07-27 Thread Fujii Masao
On 2021/07/28 6:25, Heikki Linnakangas wrote: On 27/07/2021 19:49, Fujii Masao wrote: Anyway I attached the patch that changes only xact_redo_abort() so that it calls XLogFlush() to update min recovery point. Looks good to me, thanks! FWIW, I used the attached script to reproduce this. Th

Re: Why don't update minimum recovery point in xact_redo_abort

2021-07-27 Thread Heikki Linnakangas
On 27/07/2021 19:49, Fujii Masao wrote: Anyway I attached the patch that changes only xact_redo_abort() so that it calls XLogFlush() to update min recovery point. Looks good to me, thanks! FWIW, I used the attached script to reproduce this. - Heikki # Repro for https://www.postgresql.org/mes

Re: Why don't update minimum recovery point in xact_redo_abort

2021-07-27 Thread Fujii Masao
On 2021/07/27 19:51, Michael Paquier wrote: On Tue, Jul 27, 2021 at 05:26:05PM +0900, Fujii Masao wrote: ISTM that you're right. xact_redo_abort() should call XLogFlush() to update the minimum recovery point on truncation. This seems the oversight in commit 7bffc9b7bf. Indeed. It would be n

Re: Why don't update minimum recovery point in xact_redo_abort

2021-07-27 Thread Michael Paquier
On Tue, Jul 27, 2021 at 05:26:05PM +0900, Fujii Masao wrote: > ISTM that you're right. xact_redo_abort() should call XLogFlush() to > update the minimum recovery point on truncation. This seems > the oversight in commit 7bffc9b7bf. Indeed. It would be nice to see some refactoring of this code as

Re: Why don't update minimum recovery point in xact_redo_abort

2021-07-27 Thread Fujii Masao
On 2021/07/27 2:38, 蔡梦娟(玊于) wrote: Hi, all Recently, I got a PANIC while restarts standby, which can be reproduced by the following steps, based on pg 11: 1. begin a transaction in primary node; 2. create a table in the transaction; 3. insert lots of data into the table; 4. do a checkpoint,