Re: WaitForOlderSnapshots refactoring

2018-08-21 Thread Peter Eisentraut
On 20/08/2018 14:39, Andres Freund wrote: >> The question is where to put it. This patch just leaves it static in >> indexcmds.c, which doesn't help other uses. A sensible place might be a >> new src/backend/commands/common.c. Or we make it non-static in >> indexcmds.c when the need arises. > Wh

Re: WaitForOlderSnapshots refactoring

2018-08-20 Thread Andres Freund
Hi, On 2018-08-20 14:35:34 +0200, Peter Eisentraut wrote: > The attached patch factors out the CREATE INDEX CONCURRENTLY code that > waits for transactions with older snapshots to finish into a new > function WaitForOlderSnapshots(). > This refactoring was part of a previously posted REINDEX CONC