Re: Wait events for delayed checkpoints

2023-10-12 Thread Thomas Munro
On Fri, Oct 13, 2023 at 2:19 PM Robert Haas wrote: > On Thu, Oct 12, 2023 at 7:09 PM Michael Paquier wrote: > > HaveVirtualXIDsDelayingChkpt() does immediately a LWLockAcquire() > > which would itself report a wait event for ProcArrayLock, overwriting > > this new one, no? > > Ah, right: the wait

Re: Wait events for delayed checkpoints

2023-10-12 Thread Robert Haas
On Thu, Oct 12, 2023 at 7:09 PM Michael Paquier wrote: > On Thu, Oct 12, 2023 at 01:32:29PM -0400, Robert Haas wrote: > > IPC seems right to me. Yeah, a timeout is being used, but as you say, > > that's an implementation detail. > > > > +1 for the idea, too. > > Agreed that timeout makes little se

Re: Wait events for delayed checkpoints

2023-10-12 Thread Michael Paquier
On Thu, Oct 12, 2023 at 01:32:29PM -0400, Robert Haas wrote: > IPC seems right to me. Yeah, a timeout is being used, but as you say, > that's an implementation detail. > > +1 for the idea, too. Agreed that timeout makes little sense in this context, and IPC looks correct. +pgstat_report_

Re: Wait events for delayed checkpoints

2023-10-12 Thread Robert Haas
On Wed, Oct 11, 2023 at 9:13 PM Thomas Munro wrote: > You can't tell if your checkpointer is spending a lot of time waiting > around for flags in delayChkptFlags to clear. Trivial patch to add > that. I've managed to see it a few times when checkpointing > repeatedly with a heavy pgbench workloa